Differential D15262

Add netdump hooks for iflib.
ClosedPublic
Actions

Authored by markj on May 1 2018, 5:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 17, 10:12 AM

	Unknown Object (File)
	Sun, May 17, 8:06 AM

	Unknown Object (File)
	Sun, May 17, 5:24 AM

	Unknown Object (File)
	Sun, May 17, 5:24 AM

	Unknown Object (File)
	Sat, May 16, 5:18 PM

	Unknown Object (File)
	Wed, May 13, 4:34 PM

	Unknown Object (File)
	Wed, May 6, 9:28 AM

	Unknown Object (File)
	Mon, May 4, 2:47 PM

Subscribers

Details

Reviewers

shurd
kmacy

Commits

rS333291: Add netdump support to iflib.

Test Plan

Tested with em (me), igb (me), ixgbe (sbruno), bnxt (sbruno)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16394
Build 16320: arc lint + arc unit

Event Timeline

markj created this revision.May 1 2018, 5:24 PM

Herald added a reviewer: shurd. · View Herald TranscriptMay 1 2018, 5:24 PM

Herald added a subscriber: ae. · View Herald Transcript

Harbormaster completed remote builds in B16385: Diff 42049.May 1 2018, 5:24 PM

markj edited the test plan for this revision. (Show Details)May 1 2018, 5:59 PM

markj added a reviewer: kmacy.

shurd added inline comments.May 1 2018, 6:18 PM

sys/net/iflib.c
6063	Wouldn't we need a NETDUMP_END case that calls txd_flush() in case it wasn't called in the last iflib_txd_db_check()?
6102	This is the first thing that iflib_completed_tx_reclaim() does... do we need to call it here too?

markj added inline comments.May 1 2018, 6:21 PM

sys/net/iflib.c
6063	The netdump transmit method already forces a flush after every packet.
6102	Oh, indeed. Looks like we do not - I'm not sure why I included it here.

shurd added inline comments.May 1 2018, 6:50 PM

sys/net/iflib.c
6063	Oh... is that just to simplify state, or to lower TX latency?

markj added inline comments.May 1 2018, 6:53 PM

sys/net/iflib.c
6063	It's basically a requirement of the interface. In some cases the client code will wait for an ACK from the server after transmitting a packet. This could be changed, but as you suggested, it's simpler to just flush after each transmit.

Remove unneeded iflib_tx_credits_update() call

Harbormaster completed remote builds in B16394: Diff 42063.May 2 2018, 2:47 PM

markj marked 2 inline comments as done.May 2 2018, 2:47 PM

lgtm

This revision is now accepted and ready to land.May 2 2018, 5:11 PM

kmacy accepted this revision.May 3 2018, 3:44 AM

Closed by commit rS333291: Add netdump support to iflib. (authored by markj). · Explain WhyMay 6 2018, 12:58 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2018, 12:58 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

93 lines

Diff 42063

sys/net/iflib.c

Loading...