Page MenuHomeFreeBSD

replace locking in swap reservation with fetchadd
AbandonedPublic

Authored by kmacy on Apr 30 2018, 7:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 28, 8:23 AM
Unknown Object (File)
Sun, Oct 26, 5:24 AM
Unknown Object (File)
Fri, Oct 24, 12:13 AM
Unknown Object (File)
Tue, Oct 21, 11:42 PM
Unknown Object (File)
Tue, Oct 21, 11:42 PM
Unknown Object (File)
Tue, Oct 21, 12:06 PM
Unknown Object (File)
Oct 11 2025, 6:03 AM
Unknown Object (File)
Sep 24 2025, 12:34 AM
Subscribers

Details

Reviewers
jeff
kib
markj
Summary

This is a straightforward conversion of the locking around swap_reservation and ui_vmsize to use atomic_fetchadd. This gives a 40% speedup on brk1_processes in will-it-scale. Moving the bottleneck to the invl_gen_mtx. The atomics again become bottlenecks if D15231 is put in place and so ultimately a more sophisticated pcpu scheme is warranted.

I realized I may have to keep the locked version around for ppc32 and MIPS. Suggestions welcome, otherwise I'll abandon.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 16349

Event Timeline

sys/vm/swap_pager.c
208

I would not call this variable 'new'.

Also, I do not believe that the patch compiles on 32bit architectures.

295

This does not compole for kernels without RACCT.