Differential D15129

armv7 patch without switching kernels to armv7 by default
AbandonedPublic
Actions

Authored by linimon on Apr 18 2018, 10:21 PM.

Tags

None

Referenced Files

	F106653830: D15129.diff
	Fri, Jan 3, 10:50 AM

	Unknown Object (File)
	Nov 7 2024, 10:47 AM

	Unknown Object (File)
	Sep 12 2024, 8:39 PM

	Unknown Object (File)
	Sep 9 2024, 3:38 AM

	Unknown Object (File)
	Sep 9 2024, 1:55 AM

	Unknown Object (File)
	Sep 8 2024, 8:00 AM

	Unknown Object (File)
	Sep 8 2024, 3:41 AM

	Unknown Object (File)
	Sep 8 2024, 12:54 AM

View All 38 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

imp
gonzo
manu

Summary

These are the infrastructure changes that allow the use of armv7 as a valid ARCH value.

The previous patch switched to armv7 as a default for 32-bit kernels. That is excluded here.

Other than that, two changes to UPDATING which were missed are included; and some spelling was fixed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

linimon created this revision.Apr 18 2018, 10:21 PM

Herald added subscribers: Contributor Reviews (src), emaste, andrew and 2 others. · View Herald TranscriptApr 18 2018, 10:21 PM

This is fine, but I still fail to see the problem with switching the kernels. The issues are orthogonal anyway, so we can go ahead and do this merge since this merge changes no defaults.

This revision is now accepted and ready to land.Apr 18 2018, 10:25 PM

linimon mentioned this in D15071: Backport armv7 architecture support to stable/11.Apr 18 2018, 10:26 PM

imp added inline comments.Apr 18 2018, 10:26 PM

UPDATING
55–57	This isn't relevant if you aren't changing the kernel configs.

Incorporate suggested change to UPDATING.

This revision now requires review to proceed.Apr 18 2018, 10:36 PM

linimon added reviewers: gonzo, manu.Apr 18 2018, 10:36 PM

hey Mark, sorry to quibble, but I have a suggestion on the UPDATING entry. I should have been clearer last time.

UPDATING
55	I'd add 'If you are opting into armv7, you must change the kernel config from armv6 to armv7 for the kernel you're using, otherwise uname -p may be incorrect, resulting in some configuration scripts choosing sub-optimal defaults. In addition, there are packages for armv6, but no patches yet for armv7. You'll need to add an alias to pkg.conf to get packages until that issue is resolved.' or something like that.

Fix UPDATING.

OK. This is ready to land.

This revision is now accepted and ready to land.Apr 20 2018, 2:42 PM

Looks OK to me

Fix the fact that new file std.conf.armv7 was forgotten.

Remove the patch for std.conf.armv6, it is OBE.

This revision now requires review to proceed.Apr 20 2018, 8:46 PM

Overcome by events.

Revision Contents
Changeset List

Path

Size

4 lines

5 lines

Makefile.libcompat

4 lines

4 lines

gnu/

usr.bin/

binutils/

4 lines

as/

5 lines

ld/

3 lines

libbfd/

4 lines

cc/

7 lines

3 lines

gdb/

2 lines

libgdb/

2 lines

lib/

clang/

4 lines

libc/

2 lines

arm/

2 lines

aeabi/

6 lines

gen/

2 lines

sys/

2 lines

libcompiler_rt/

2 lines

msun/

arm/

2 lines

share/

mk/

27 lines

local.meta.sys.mk

2 lines

2 lines

2 lines

sys/

arm/

conf/

2 lines

include/

10 lines

conf/

2 lines

24 lines

1 line

2 lines

1 line

1 line

modules/

4 lines

cloudabi32/

2 lines

Diff 41642

Makefile

Loading...

Makefile.inc1

Loading...

Makefile.libcompat

Loading...

UPDATING

Loading...

gnu/usr.bin/binutils/Makefile.inc0

Loading...

gnu/usr.bin/binutils/as/Makefile

Loading...

gnu/usr.bin/binutils/ld/Makefile.arm

Loading...

gnu/usr.bin/binutils/libbfd/Makefile.arm

Loading...

gnu/usr.bin/cc/Makefile.inc

Loading...

gnu/usr.bin/cc/Makefile.tgt

Loading...

gnu/usr.bin/gdb/Makefile.inc

Loading...

gnu/usr.bin/gdb/libgdb/Makefile

Loading...

lib/clang/llvm.build.mk

Loading...

lib/libc/Makefile

Loading...

lib/libc/arm/Makefile.inc

Loading...

lib/libc/arm/aeabi/Makefile.inc

Loading...

lib/libc/arm/gen/Makefile.inc

Loading...

lib/libc/sys/Makefile.inc

Loading...

lib/libcompiler_rt/Makefile.inc

Loading...

lib/msun/arm/Makefile.inc

Loading...

share/mk/bsd.cpu.mk

Loading...

share/mk/local.meta.sys.mk

Loading...

share/mk/src.opts.mk

Loading...

share/mk/sys.mk

Loading...

sys/arm/conf/std.armv6

Loading...

sys/arm/include/param.h

Loading...

sys/conf/Makefile.arm

Loading...

sys/conf/files.arm

Loading...

sys/conf/kern.mk

Loading...

sys/conf/kern.opts.mk

Loading...

sys/conf/kern.pre.mk

Loading...

sys/conf/options.arm

Loading...

sys/modules/Makefile

Loading...

sys/modules/cloudabi32/Makefile

Loading...