Page MenuHomeFreeBSD
Differential D15046

Make lagg creation more fault tolerant
ClosedPublic
Actions

Authored by gallatin on Apr 11 2018, 5:49 PM.
Tags
None
Referenced Files
F154993582: D15046.id41567.diff
Thu, Apr 30, 1:26 PM
Unknown Object (File)
Wed, Apr 29, 1:37 PM
Unknown Object (File)
Mon, Apr 27, 6:10 PM
Unknown Object (File)
Thu, Apr 23, 8:49 PM
Unknown Object (File)
Tue, Apr 21, 11:00 PM
Unknown Object (File)
Sun, Apr 19, 9:53 AM
Unknown Object (File)
Sun, Apr 12, 5:32 AM
Unknown Object (File)
Sat, Apr 11, 10:42 PM
View All Files
Subscribers
imp

Details

Reviewers
jtl
glebius
thompsa
sbruno
kbowling
Commits
rS332645: Make lagg creation more fault tolerant
Summary
  • Warn, don't exit, when SIOCSLAGGPORT returns an error.

When we exit with an error during lagg creation, a single failed NIC (which no longer attaches) can prevent lagg creation and other configuration, such as adding an IPv4 address, and thus leave a machine unreachable.

  • Preserve non-EEXISTS errors for exit status from SIOCSLAGGPORT, in case scripts are looking for it. Hopefully this can be extended if other parts of ifconfig can allow a "soft" failure.
  • Improve the warning message to mention what lagg and what member are problematic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sbin/
ifconfig/
2 lines
1 line
7 lines
4 lines
14 lines

Diff 41567

View Options

head/sbin/ifconfig/ifclone.c

Loading...
View Options

head/sbin/ifconfig/ifconfig.h

Loading...
View Options

head/sbin/ifconfig/ifconfig.c

Loading...
View Options

head/sbin/ifconfig/ifgroup.c

Loading...
View Options

head/sbin/ifconfig/iflagg.c

Loading...