Differential D15046

Make lagg creation more fault tolerant
ClosedPublic
Actions

Authored by gallatin on Apr 11 2018, 5:49 PM.

Tags

None

Referenced Files

	F169128621: D15046.id.diff
	Mon, Aug 31, 12:42 PM

	F169092745: D15046.id41567.diff
	Mon, Aug 31, 9:38 AM

	F169008093: D15046.id41374.diff
	Mon, Aug 31, 3:00 AM

	Unknown Object (File)
	Sun, Aug 30, 11:16 AM

	Unknown Object (File)
	Thu, Aug 27, 1:51 PM

	Unknown Object (File)
	Wed, Aug 26, 2:34 PM

	Unknown Object (File)
	Wed, Aug 26, 3:38 AM

	Unknown Object (File)
	Wed, Aug 26, 3:07 AM

Subscribers

Details

Reviewers

jtl
glebius
thompsa
sbruno
kbowling

Commits

rS332645: Make lagg creation more fault tolerant

Summary

Warn, don't exit, when SIOCSLAGGPORT returns an error.

When we exit with an error during lagg creation, a single failed NIC (which no longer attaches) can prevent lagg creation and other configuration, such as adding an IPv4 address, and thus leave a machine unreachable.

Preserve non-EEXISTS errors for exit status from SIOCSLAGGPORT, in case scripts are looking for it. Hopefully this can be extended if other parts of ifconfig can allow a "soft" failure.

Improve the warning message to mention what lagg and what member are problematic.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 16105

Event Timeline

gallatin created this revision.Apr 11 2018, 5:49 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 11 2018, 5:49 PM

Harbormaster completed remote builds in B16105: Diff 41374.Apr 11 2018, 5:49 PM

jtl accepted this revision.Apr 11 2018, 5:56 PM

This revision is now accepted and ready to land.Apr 11 2018, 5:56 PM

glebius accepted this revision.Apr 12 2018, 9:12 PM

Closed by commit rS332645: Make lagg creation more fault tolerant (authored by gallatin). · Explain WhyApr 17 2018, 12:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

2 lines

1 line

7 lines

4 lines

14 lines

Diff 41374

sbin/ifconfig/ifclone.c

Loading...

sbin/ifconfig/ifconfig.h

Loading...

sbin/ifconfig/ifconfig.c

Loading...

sbin/ifconfig/ifgroup.c

Loading...

sbin/ifconfig/iflagg.c

Loading...