Add 32-bit compat for ioctls that take struct ifgroupreq.
ClosedPublic
Actions

Authored by brooks on Apr 4 2018, 4:42 PM.

Details

Reviewers

kib
emaste

Commits

rS332493: MFC r332088:
rS332088: Add 32-bit compat for ioctls that take struct ifgroupreq.

Summary

Use an accessor to access ifgr_group and ifgr_groups.

Use an macro CASE_IOC_IFGROUPREQ(cmd) in place of case statements such
as "case SIOCAIFGROUP:". This avoids poluting the switch statements
with large numbers of #ifdefs.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15981
Build 15968: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 4 2018, 4:42 PM

Herald added a subscriber: ae. · View Herald TranscriptApr 4 2018, 4:42 PM

Harbormaster completed remote builds in B15974: Diff 41099.Apr 4 2018, 4:42 PM

kib accepted this revision.Apr 4 2018, 5:44 PM

kib added inline comments.

sys/net/if.c
2853–2854	May be consider fixing style by moving ifgr declaration at top, and removing useless {}.

This revision is now accepted and ready to land.Apr 4 2018, 5:44 PM

Avoid unneeded ifgr temporary and be consistant about casting from data.

This revision now requires review to proceed.Apr 4 2018, 9:46 PM

Harbormaster completed remote builds in B15981: Diff 41110.Apr 4 2018, 9:46 PM

kib accepted this revision.Apr 4 2018, 9:55 PM

This revision is now accepted and ready to land.Apr 4 2018, 9:55 PM

Closed by commit rS332088: Add 32-bit compat for ioctls that take struct ifgroupreq. (authored by brooks). · Explain WhyApr 5 2018, 10:15 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptApr 5 2018, 10:15 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.h

2 lines

if.c

92 lines

Diff 41110

View Options

sys/net/if.h