geom: squash g_attribute kernel message by using correctly sized buffers
ClosedPublic
Actions

Authored by sbruno on Apr 4 2018, 5:02 PM.

Details

Reviewers

avg
cem
swills
imp

Commits

rS332070: Squash error from geom by sizing ident strings to DISK_IDENT_SIZE.

Summary

use DISK_IDENT_SIZE from disk.h so that this doesn't happen again.

g_handleattr: md1 bio_length 24 strlen 31 -> EFAULT

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15979
Build 15966: arc lint + arc unit

Event Timeline

sbruno created this revision.Apr 4 2018, 5:02 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 4 2018, 5:02 PM

Harbormaster completed remote builds in B15977: Diff 41102.Apr 4 2018, 5:02 PM

sbruno edited the summary of this revision. (Show Details)Apr 4 2018, 5:04 PM

So it's OK as it is, but maybe including attribute name will help short-circuit trouble in the future.

sys/geom/geom_subr.c
1052–1053	You should print attribute here too.

This revision is now accepted and ready to land.Apr 4 2018, 5:13 PM

While you are here, could you please fix g_label_disk_ident_taste as well?
It has a more reasonable sized buffer (100), but still would be nice to use the proper constant.

kevans added a subscriber: kevans.Apr 4 2018, 5:28 PM

Add g_label_disk_ident_taste() to our list of fixes.

Add display of attribute passed into g_handleattr().

This revision now requires review to proceed.Apr 4 2018, 6:17 PM

Harbormaster completed remote builds in B15979: Diff 41106.Apr 4 2018, 6:17 PM

In D14962#314735, @avg wrote:

While you are here, could you please fix g_label_disk_ident_taste as well?
It has a more reasonable sized buffer (100), but still would be nice to use the proper constant.

Bah, yeah. I've added that.

sbruno marked an inline comment as done.Apr 4 2018, 6:17 PM

+1 avg's suggestion as well.

This revision is now accepted and ready to land.Apr 4 2018, 6:19 PM

imp accepted this revision.Apr 4 2018, 10:14 PM

Closed by commit rS332070: Squash error from geom by sizing ident strings to DISK_IDENT_SIZE. (authored by sbruno). · Explain WhyApr 5 2018, 1:56 PM

This revision was automatically updated to reflect the committed changes.