Differential D14910

Document and enforce assumptions about struct (in6_)ifreq.
ClosedPublic
Actions

Authored by brooks on Mar 30 2018, 5:43 PM.

Tags

None

Referenced Files

	F114614852: D14910.diff
	Mon, Apr 14, 11:09 AM

	Unknown Object (File)
	Mon, Apr 14, 4:53 AM

	Unknown Object (File)
	Mon, Apr 14, 12:44 AM

	Unknown Object (File)
	Mon, Apr 14, 12:22 AM

	Unknown Object (File)
	Sun, Apr 13, 11:41 PM

	Unknown Object (File)
	Sun, Apr 13, 11:13 PM

	Unknown Object (File)
	Mar 11 2025, 12:00 AM

	Unknown Object (File)
	Mar 9 2025, 7:37 AM

View All 64 Files

Subscribers

Details

Reviewers

kib
emaste

Commits

rS331831: Document and enforce assumptions about struct (in6_)ifreq.

Summary

The two types must be type-punnable for shared members of ifr_ifru. This allows compatibility accessors to be shared.

There must be no padding gap between ifr_name and ifr_ifru. This is assumed in tcpdump's use of SIOCGIFFLAGS output which attempts to be broadly portable. This is true for all current architectures, but very large (256-bit) fat-pointers could violate this invariant.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15899
Build 15899: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 30 2018, 5:43 PM

Herald added subscribers: ae, vangyzen. · View Herald TranscriptMar 30 2018, 5:43 PM

Harbormaster completed remote builds in B15895: Diff 40917.Mar 30 2018, 5:43 PM

Use _Static_assert which is defined in sys/cdefs.h rather than CTASSERT
Use 0 not NULL for files with strange include orders.

Harbormaster completed remote builds in B15898: Diff 40921.Mar 30 2018, 6:23 PM

brooks added reviewers: kib, emaste.Mar 30 2018, 6:24 PM

kib added inline comments.Mar 30 2018, 8:01 PM

sys/net/if.h
428 ↗	(On Diff #40921)	I suggest to move the asserts to some .c file. There is no benefits of forcing all users of if.h to recheck the same stuff, one assert is enough for the developer to notice the issue.

Move asserts to .c files.

Harbormaster completed remote builds in B15899: Diff 40926.Mar 30 2018, 8:33 PM

kib accepted this revision.Mar 30 2018, 8:53 PM

This revision is now accepted and ready to land.Mar 30 2018, 8:53 PM

Closed by commit rS331831: Document and enforce assumptions about struct (in6_)ifreq. (authored by brooks). · Explain WhyMar 30 2018, 9:39 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 30 2018, 9:39 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

7 lines

netinet6/

8 lines

Diff 40926

sys/net/if.c

Loading...

sys/netinet6/in6.c

Loading...