Make sure the keyboard repeat values are range checked in a standard way.
Valid values are listed by the kbdcontrol(1) manual page.
MFC after: 1 week
Sponsored by: Mellanox Technologies
Details
Details
- Reviewers
johalun0_gmail.com
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 15863
Event Timeline
Comment Actions
Seem to help against ukbd irqs but the problem is still there. I now discovered how I can get the same behavior in i3 and X.
I did this in xfce4-terminal, don't know if it has to be that or not. Hold down CTRL (with USB keyboard), press any other key and let go, but hold down CTRL the whole time. Now interrupt storms start on CPU 0 timer.
Normal operation (just doing nothing)
kernel`ithread_loop 4 kernel`trash_dtor 4 kernel`memcpy 4 kernel`witness_lock 5 kernel`_isitmyx 5 kernel`fill_kinfo_proc 6 kernel`bzero 7 dtrace.ko`dtrace_dynvar_clean 7 kernel`__mtx_unlock_flags 10 kernel`cpu_idle 12 i915kms.ko`fw_domains_get 12 kernel`__mtx_lock_flags 14 kernel`AcpiNsSearchAndEnter 16 kernel`witness_checkorder 16 kernel`witness_unlock 19 kernel`spinlock_exit 58 kernel`acpi_cpu_idle 83223
With irq storm
dtrace.ko`dtrace_dynvar_clean 4 kernel`0xffffffff809dc135 5 kernel`AcpiNsSearchAndEnter 12 kernel`lock_mtx 13 i915kms.ko`fw_domains_get 15 kernel`callout_when 33 kernel`unlock_mtx 45 kernel`spinlock_enter 53 kernel`callout_reset_sbt_on 82 kernel`__mtx_lock_spin_flags 95 kernel`ukbd_timeout 108 kernel`softclock_call_cc 108 kernel`witness_lock 112 kernel`witness_checkorder 133 kernel`__mtx_assert 143 kernel`__mtx_unlock_flags 178 kernel`usbd_in_polling_mode 189 kernel`cpu_idle 197 kernel`ukbd_interrupt 201 kernel`__mtx_lock_flags 201 kernel`witness_unlock 328 kernel`lock_delay 616 kernel`memcpy 663 kernel`spinlock_exit 11652 kernel`acpi_cpu_idle 60365