Differential D14865

Add support for iwm 3168 cards
AbandonedPublic
Actions

Authored by eadler on Mar 27 2018, 9:08 AM.

Tags

None

Referenced Files

	F166555274: D14865.diff
	Fri, Aug 14, 9:58 AM

	F166553393: D14865.id.diff
	Fri, Aug 14, 9:25 AM

	F166551999: D14865.diff
	Fri, Aug 14, 8:57 AM

	F166544349: D14865.diff
	Fri, Aug 14, 6:29 AM

	F166494215: D14865.id40825.diff
	Thu, Aug 13, 8:28 PM

	Unknown Object (File)
	Wed, Aug 12, 11:49 AM

	Unknown Object (File)
	Wed, Aug 12, 7:33 AM

	Unknown Object (File)
	Tue, Aug 11, 10:57 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS331665: [iwm] Add support for iwm 3168 cards

Test Plan

Compiles, loads, and can produce a working wlan0 device.

iwm0@pci0:5:0:0:        class=0x028000 card=0x21108086 chip=0x24fb8086 rev=0x10 hdr=0x00
    vendor     = 'Intel Corporation'
    device     = 'Dual Band Wireless-AC 3168NGW [Stone Peak]'
    class      = network
[94829] iwm0: <Intel(R) Dual Band Wireless AC 3168> mem 0xef700000-0xef701fff at device 0.0 on pci5
[94829] iwm0: hw rev 0x220, fw ver 22.361476.0, address 28:c6:3f:15:43:c5

Here is where I need help:

iwm0: could not initiate scan

Reference https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224886

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15839
Build 15847: arc lint + arc unit

Event Timeline

eadler created this revision.Mar 27 2018, 9:08 AM

Herald added a reviewer: manpages. · View Herald TranscriptMar 27 2018, 9:08 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B15821: Diff 40785.Mar 27 2018, 9:08 AM

eadler edited the test plan for this revision. (Show Details)Mar 27 2018, 9:11 AM

kevans added a subscriber: kevans.Mar 27 2018, 12:55 PM

kevans added inline comments.

sys/dev/iwm/if_iwm.c
5687	Nit: tab, rather than space, after #define

ivadasz added a subscriber: ivadasz.Mar 27 2018, 6:24 PM

ivadasz added inline comments.

sys/conf/files
1991–1995	You should add .c and .fwo rules as well for the iwm3168 firmware blob.

eadler edited the test plan for this revision. (Show Details)Mar 28 2018, 12:31 AM

per @kevans and @ivadasz

Harbormaster completed remote builds in B15839: Diff 40825.Mar 28 2018, 12:38 AM

eadler edited the test plan for this revision. (Show Details)Mar 28 2018, 2:34 AM

eadler edited the test plan for this revision. (Show Details)Mar 28 2018, 6:18 AM

Closed in r331665

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

3 lines

4 lines

sys/

conf/

14 lines

contrib/

dev/

iwm/

iwm-3168-22.fw.uu

22849 lines

dev/

iwm/

2 lines

8 lines

if_iwm_config.h

1 line

modules/

iwmfw/

1 line

6 lines

Diff 40825

share/man/man4/iwm.4

Loading...

share/man/man4/iwmfw.4

Loading...

sys/conf/files

Loading...

sys/contrib/dev/iwm/iwm-3168-22.fw.uu

Loading...

sys/dev/iwm/if_iwm.c

Loading...

sys/dev/iwm/if_iwm_7000.c

Loading...

sys/dev/iwm/if_iwm_config.h

Loading...

sys/modules/iwmfw/Makefile

Loading...

sys/modules/iwmfw/iwm3168fw/

Loading...

sys/modules/iwmfw/iwm3168fw/Makefile

Loading...