Page MenuHomeFreeBSD
Differential D14873

Improve copy-and-paste versions of SIOCGIFADDR.
ClosedPublic
Actions

Authored by brooks on Mar 27 2018, 6:48 PM.
Tags
None
Referenced Files
F141039680: D14873.diff
Wed, Dec 31, 2:04 AM
F141039677: D14873.diff
Wed, Dec 31, 2:04 AM
F141039671: D14873.diff
Wed, Dec 31, 2:04 AM
Unknown Object (File)
Fri, Dec 12, 1:40 PM
Unknown Object (File)
Nov 26 2025, 9:57 PM
Unknown Object (File)
Nov 24 2025, 2:28 AM
Unknown Object (File)
Nov 22 2025, 10:57 PM
Unknown Object (File)
Nov 21 2025, 10:19 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
kib
emaste
jhb
Commits
rS332160: MFC r331648:
rS332159: MFC r331648:
rS331648: Improve copy-and-pasted versions of SIOCGIFADDR.
Summary

The original implementation used a reference to ifr_data and a cast to
do the equivalent of accessing ifr_addr. This was copied multiple
times since 1996.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15834
Build 15842: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 27 2018, 6:48 PM
Herald added a subscriber: ae. · View Herald TranscriptMar 27 2018, 6:48 PM
Harbormaster completed remote builds in B15834: Diff 40814.Mar 27 2018, 6:48 PM
brooks added reviewers: kib, emaste, jhb.Mar 27 2018, 6:49 PM

This is the first of several changes to clean up use of ifr_data before placing all remaining access behind an accessor function.

kib accepted this revision.Mar 27 2018, 8:17 PM
This revision is now accepted and ready to land.Mar 27 2018, 8:17 PM
Closed by commit rS331648: Improve copy-and-pasted versions of SIOCGIFADDR. (authored by brooks). · Explain WhyMar 27 2018, 8:52 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMar 27 2018, 8:52 PM

Revision Contents
Changeset List

PathSize
sys/
net/
7 lines
9 lines
11 lines
9 lines
10 lines
8 lines
ofed/
drivers/
infiniband/
ulp/
ipoib/
9 lines

Diff 40814

View Options

sys/net/if_arcsubr.c

Loading...
View Options

sys/net/if_ethersubr.c

Loading...
View Options

sys/net/if_fddisubr.c

Loading...
View Options

sys/net/if_fwsubr.c

Loading...
View Options

sys/net/if_iso88025subr.c

Loading...
View Options

sys/net/if_vlan.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

Loading...