Page MenuHomeFreeBSD
Differential D14811

Move uio enums to sys/_uio.h.
ClosedPublic
Actions

Authored by brooks on Mar 23 2018, 9:24 PM.
Tags
None
Referenced Files
F170796236: D14811.diff
Sun, Sep 6, 4:38 PM
Unknown Object (File)
Fri, Sep 4, 8:51 PM
Unknown Object (File)
Fri, Sep 4, 9:00 AM
Unknown Object (File)
Thu, Sep 3, 11:46 AM
Unknown Object (File)
Thu, Sep 3, 9:29 AM
Unknown Object (File)
Thu, Sep 3, 3:53 AM
Unknown Object (File)
Wed, Sep 2, 2:32 PM
Unknown Object (File)
Wed, Sep 2, 12:29 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
cem
kib
jhb
Commits
rS331621: Move uio enums to sys/_uio.h.
Summary

Include _uio.h instead of uio.h in several headers to reduce header
polution.

A few places that relied on header polution to get the uio.h header.

I have not moved struct uio as many more things that use it rely on
header polution to get other definitions from uio.h.

Test Plan

do a tinderbox run

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15748
Build 15766: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 23 2018, 9:24 PM
Harbormaster completed remote builds in B15748: Diff 40654.Mar 23 2018, 9:24 PM
brooks updated this revision to Diff 40753.Mar 26 2018, 6:02 PM
  • Add another missing sys/uio.h
Harbormaster completed remote builds in B15804: Diff 40753.Mar 26 2018, 6:02 PM
brooks added reviewers: markj, cem, kib, jhb.Mar 26 2018, 10:49 PM

Now passes tinderbox (to the extent that universe built at all over the weekend) so ready for review.

cem accepted this revision.Mar 26 2018, 10:59 PM
This revision is now accepted and ready to land.Mar 26 2018, 10:59 PM
kib accepted this revision.Mar 26 2018, 11:05 PM
markj accepted this revision.Mar 26 2018, 11:08 PM
Closed by commit rS331621: Move uio enums to sys/_uio.h. (authored by brooks). · Explain WhyMar 27 2018, 3:20 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMar 27 2018, 3:20 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
freebsd32/
1 line
dev/
md/
1 line
kern/
1 line
sys/
52 lines
2 lines
2 lines
7 lines
12 lines

Diff 40654

View Options

sys/compat/freebsd32/freebsd32_ioctl.c

Loading...
View Options

sys/dev/md/md.c

Loading...
View Options

sys/kern/tty_pts.c

Loading...
View Options

sys/sys/_uio.h

Loading...
View Options

sys/sys/imgact.h

Loading...
View Options

sys/sys/namei.h

Loading...
View Options

sys/sys/syscallsubr.h

Loading...
View Options

sys/sys/uio.h

Loading...