Add a request structure and make the implementation use it.
ClosedPublic
Actions

Authored by brooks on Mar 15 2018, 6:22 PM.

Details

Reviewers

cem
kib
markj

Commits

rS331030: Add a request structure and make the implementation use it.

Summary

This allows compatibility translation to take place on the stack (md_ioctl is too big) and is more suitable as a public interface within the kernel than the kern_ioctl interface.

Except for the initialization of the md_req from the md_ioctl
(including detection of kernel md_file pointers) and the updating
of the md_ioctl prior to return, this is a mechanical replacment
of md_ioctl and mdio with md_req and mdr.

Test Plan

Passes mdconfig tests.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15589
Build 15625: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 15 2018, 6:22 PM

Harbormaster completed remote builds in B15586: Diff 40325.Mar 15 2018, 6:22 PM

brooks added reviewers: cem, kib, markj.Mar 15 2018, 6:24 PM

brooks edited the summary of this revision. (Show Details)Mar 15 2018, 6:49 PM

brooks edited the test plan for this revision. (Show Details)

kib accepted this revision.Mar 15 2018, 6:51 PM

This revision is now accepted and ready to land.Mar 15 2018, 6:51 PM

cem accepted this revision.Mar 15 2018, 7:01 PM

cem added inline comments.

sys/dev/md/md.c
1626–1627	As long as this is a totally new ABI, this limit could be raised. If we care.
1661–1662	Will this be removed when kernel users are converted away from the ioctl API?

brooks added inline comments.Mar 15 2018, 8:37 PM

sys/dev/md/md.c
1626–1627	I'll make the request flexible.
1661–1662	That's the plan.

markj accepted this revision.Mar 15 2018, 8:41 PM

markj added inline comments.

sys/dev/md/md.c
1825–1848	Zap this stray semicolon while you're here?

Whitespace fix.
Remove unused md_base.
Allow md_pad's length to vary.
Change md_pad to md_units in md_req.

This revision now requires review to proceed.Mar 15 2018, 9:04 PM

Harbormaster completed remote builds in B15588: Diff 40330.Mar 15 2018, 9:04 PM

brooks marked 4 inline comments as done.Mar 15 2018, 9:13 PM

brooks added inline comments.

sys/dev/md/md.c
1825–1848	@markj: I seem to have lost a race with your review and my update and I can't figure out how go get phabricator to show me where the comment should go and the current location doesn't make sense.