Page MenuHomeFreeBSD

Add a request structure and make the implementation use it.
ClosedPublic

Authored by brooks on Mar 15 2018, 6:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 5:24 AM
Unknown Object (File)
Nov 19 2024, 1:56 AM
Unknown Object (File)
Nov 18 2024, 8:24 PM
Unknown Object (File)
Nov 18 2024, 8:02 PM
Unknown Object (File)
Nov 18 2024, 7:52 PM
Unknown Object (File)
Nov 18 2024, 7:49 PM
Unknown Object (File)
Nov 18 2024, 4:50 PM
Unknown Object (File)
Nov 18 2024, 4:50 PM
Subscribers

Details

Summary

This allows compatibility translation to take place on the stack (md_ioctl is too big) and is more suitable as a public interface within the kernel than the kern_ioctl interface.

Except for the initialization of the md_req from the md_ioctl
(including detection of kernel md_file pointers) and the updating
of the md_ioctl prior to return, this is a mechanical replacment
of md_ioctl and mdio with md_req and mdr.

Test Plan

Passes mdconfig tests.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15586
Build 15622: arc lint + arc unit

Event Timeline

brooks edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mar 15 2018, 6:51 PM
cem added inline comments.
sys/dev/md/md.c
1841

As long as this is a totally new ABI, this limit could be raised. If we care.

1890–1891

Will this be removed when kernel users are converted away from the ioctl API?

sys/dev/md/md.c
1841

I'll make the request flexible.

1890–1891

That's the plan.

markj added inline comments.
sys/dev/md/md.c
1919

Zap this stray semicolon while you're here?

  • Whitespace fix.
  • Remove unused md_base.
  • Allow md_pad's length to vary.
  • Change md_pad to md_units in md_req.
This revision now requires review to proceed.Mar 15 2018, 9:04 PM
brooks added inline comments.
sys/dev/md/md.c
1919

@markj: I seem to have lost a race with your review and my update and I can't figure out how go get phabricator to show me where the comment should go and the current location doesn't make sense.

  • Remove an extra semicolon.
This revision is now accepted and ready to land.Mar 15 2018, 9:19 PM
This revision was automatically updated to reflect the committed changes.