extres/regulators: Add sysctls for regulator
ClosedPublic
Actions

Authored by manu on Mar 3 2018, 7:42 PM.

Details

Reviewers

mmel
• ian

Group Reviewers

ARM
arm64

Commits

rS330758: extres/regulators: Add sysctls for regulators

Summary

For each regulators create an hw.<regname>. :
uvolt: Current value
always_on: 1 If the reg is always on
boot_on: 1 If the reg is set at boot time
enable_cnt: Number of consumer(s)
enable_delay: Delay before enabling the regulator
ramp_delay: The Ramp delay
max_uamp: The maximum value of the regulator in uAmps
min_uamp: The minimal value of the regulator in uAmps
max_uvolt: The maximum value of the regulator in uVolts
min_uvolt: The minimal value of the regulator in uVolts

Test Plan

Tested-On: Pine64-LTS

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15360
Build 15414: arc lint + arc unit

Event Timeline

manu created this revision.Mar 3 2018, 7:42 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2018, 7:42 PM

• ian added a subscriber: • ian.Mar 3 2018, 8:19 PM

• ian added inline comments.

sys/dev/extres/regulator/regulator.c
155	Extra 'l'
165	space before else
174	Why is this not sysctl_handle_int() ?
352	leading tab vs spaces? phab is showing CTLFLAG_RD aligned differently than others, but you can't trust phab's rendering of tabs much. same with the one below.