Support both FDT and ACPI on arm64 in the pl011 driver
ClosedPublic
Actions

Authored by andrew on Feb 26 2018, 8:59 AM.

Details

Reviewers

Group Reviewers

ARM
arm64

Commits

rS330111: The Arm pl011 driver assumes it's running a devicetree based system.

Summary

The Arm pl011 driver assumes it's running a devicetree based system.
It calls OF_* functions to check if it needs to implement workarounds.
This may not be the case on arm64 where we support both FDT and ACPI.
Fix this by checking if we are booting on FDT before calling these checks.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Feb 26 2018, 8:59 AM

Harbormaster completed remote builds in B15273: Diff 39738.Feb 26 2018, 8:59 AM

emaste added a subscriber: emaste.Feb 26 2018, 1:04 PM

This looks fine to me.

It seems slightly more obfuscatory to me to split out IS_FDT and uart_pl011_bus_hwrev_fdt vs a couple of ifdefs in uart_pl011_bus_probe (although I don't object).

• ian accepted this revision.Feb 27 2018, 5:30 PM

This revision is now accepted and ready to land.Feb 27 2018, 5:30 PM

Closed by commit rS330111: The Arm pl011 driver assumes it's running a devicetree based system. (authored by andrew). · Explain WhyFeb 28 2018, 3:02 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2018, 3:02 PM