Sandbox wc(1) with fileargs.
ClosedPublic
Actions

Authored by oshogbo on Feb 17 2018, 12:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 19, 12:30 PM

	Unknown Object (File)
	Nov 20 2025, 5:27 PM

	Unknown Object (File)
	Nov 20 2025, 5:25 PM

	Unknown Object (File)
	Nov 20 2025, 5:25 PM

	Unknown Object (File)
	Nov 20 2025, 5:15 PM

	Unknown Object (File)
	Nov 18 2025, 7:54 AM

	Unknown Object (File)
	Nov 18 2025, 2:51 AM

	Unknown Object (File)
	Nov 10 2025, 12:46 AM

View All Files

Subscribers

jonathan

Details

Reviewers

cem
allanjude
emaste
bapt

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

oshogbo created this revision.Feb 17 2018, 12:28 PM

oshogbo added a reviewer: bapt.

This looks pretty clean, I like it.

usr.bin/wc/wc.c
144	Doesn't this need to be before the first use of err.h? It should be before the above if() because of the xo_warn()

This revision is now accepted and ready to land.Feb 17 2018, 5:12 PM

oshogbo added inline comments.Feb 21 2018, 9:55 PM

usr.bin/wc/wc.c
144	But this is needed only when we are in capability mode which we enter below, so if xo_warn will be called it will still have access to the NLS.

We handle now empty argc and argv.

This revision now requires review to proceed.Feb 21 2018, 9:57 PM

Looks good

usr.bin/wc/wc.c
49	should sort alphabetically before stat

allanjude accepted this revision.Feb 22 2018, 12:46 AM

This revision is now accepted and ready to land.Feb 22 2018, 12:46 AM

emaste mentioned this in D14407: Introduce cap_fileargs..Feb 23 2018, 3:25 PM

oshogbo closed this revision.Nov 12 2018, 5:59 PM

Herald added a subscriber: jonathan. · View Herald TranscriptNov 12 2018, 5:59 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

wc/

Makefile

8 lines

wc.c

30 lines

Diff 39586

View Options

usr.bin/wc/Makefile