Page MenuHomeFreeBSD
Differential D13989

Reduce code duplication for inpcb route caching
ClosedPublic
Actions

Authored by rstone on Jan 19 2018, 9:40 PM.
Tags
None
Referenced Files
F137040718: D13989.id38338.diff
Fri, Nov 21, 1:01 AM
F137039834: D13989.id.diff
Fri, Nov 21, 12:59 AM
F137039674: D13989.id38222.diff
Fri, Nov 21, 12:59 AM
F137039303: D13989.id38234.diff
Fri, Nov 21, 12:58 AM
F137038003: D13989.diff
Fri, Nov 21, 12:55 AM
Unknown Object (File)
Tue, Nov 18, 3:20 AM
Unknown Object (File)
Sun, Nov 16, 9:15 PM
Unknown Object (File)
Fri, Nov 7, 9:28 PM
View All Files
Subscribers
ae
imp
jim_netgate.com
vangyzen
wollman

Details

Reviewers
• karels
Commits
rS328271: Reduce code duplication for inpcb route caching
Summary

Add a new macro to clear both the L3 and L2 route caches, to
hopefully prevent future instances where only the L3 cache was
cleared when both should have been.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rstone created this revision.Jan 19 2018, 9:40 PM
Herald added a subscriber: ae. · View Herald TranscriptJan 19 2018, 9:40 PM
Harbormaster completed remote builds in B14490: Diff 38222.Jan 19 2018, 9:40 PM
vangyzen added a subscriber: vangyzen.Jan 19 2018, 9:58 PM
vangyzen added inline comments.
sys/net/route.h
419 ↗(On Diff #38222)

I generally prefer inline functions over macros, but this is fine.

sys/netinet/ip_output.c
305 ↗(On Diff #38222)

This drops the assignment of NULL to the local rte.

jim_netgate.com added a subscriber: jim_netgate.com.Jan 19 2018, 10:09 PM
rstone updated this revision to Diff 38234.Jan 19 2018, 11:36 PM

NULL-out rte after route cache is invalidated

Harbormaster completed remote builds in B14496: Diff 38234.Jan 19 2018, 11:36 PM
rstone marked 2 inline comments as done.Jan 19 2018, 11:38 PM
• karels added a comment.Jan 20 2018, 2:37 AM

Was there a place where only L3 was invalidated?

In any case, this seems like a good change.

wollman added a subscriber: wollman.Jan 20 2018, 5:57 PM
• karels accepted this revision.Jan 22 2018, 5:38 AM
This revision is now accepted and ready to land.Jan 22 2018, 5:38 AM
Closed by commit rS328271: Reduce code duplication for inpcb route caching (authored by rstone). · Explain WhyJan 23 2018, 3:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJan 23 2018, 3:16 AM

Revision Contents
Changeset List

PathSize
head/
sys/
net/
17 lines
netinet/
8 lines
7 lines

Diff 38338

View Options

head/sys/net/route.h

Loading...
View Options

head/sys/netinet/in_pcb.c

Loading...
View Options

head/sys/netinet/ip_output.c

Loading...