Page MenuHomeFreeBSD

Reduce code duplication for inpcb route caching
ClosedPublic

Authored by rstone on Jan 19 2018, 9:40 PM.
Tags
None
Referenced Files
F106676086: D13989.diff
Fri, Jan 3, 6:08 PM
Unknown Object (File)
Thu, Dec 26, 12:49 PM
Unknown Object (File)
Nov 30 2024, 3:09 AM
Unknown Object (File)
Nov 19 2024, 4:06 AM
Unknown Object (File)
Nov 14 2024, 4:23 AM
Unknown Object (File)
Nov 13 2024, 5:12 AM
Unknown Object (File)
Nov 1 2024, 4:43 AM
Unknown Object (File)
Oct 30 2024, 4:57 PM

Details

Summary

Add a new macro to clear both the L3 and L2 route caches, to
hopefully prevent future instances where only the L3 cache was
cleared when both should have been.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14496
Build 14638: arc lint + arc unit

Event Timeline

vangyzen added inline comments.
sys/net/route.h
419

I generally prefer inline functions over macros, but this is fine.

sys/netinet/ip_output.c
305–306

This drops the assignment of NULL to the local rte.

NULL-out rte after route cache is invalidated

Was there a place where only L3 was invalidated?

In any case, this seems like a good change.

This revision is now accepted and ready to land.Jan 22 2018, 5:38 AM
This revision was automatically updated to reflect the committed changes.