Page MenuHomeFreeBSD
Differential D13943

Cleanup kldxref sources
ClosedPublic
Actions

Authored by mhorne063_gmail.com on Jan 16 2018, 10:36 PM.
Tags
None
Referenced Files
F169399850: D13943.id.diff
Tue, Sep 1, 10:36 AM
Unknown Object (File)
Mon, Aug 31, 8:08 AM
Unknown Object (File)
Mon, Aug 31, 8:07 AM
Unknown Object (File)
Sun, Aug 30, 9:37 AM
Unknown Object (File)
Sun, Aug 30, 9:07 AM
Unknown Object (File)
Sun, Aug 30, 9:06 AM
Unknown Object (File)
Sun, Aug 30, 7:58 AM
Unknown Object (File)
Sun, Aug 30, 6:28 AM
View All Files
Subscribers
andrew
imp

Details

Reviewers
emaste
cem
kib
Commits
rS328094: kldxref: improve style(9)
Summary

There are some style inconsistencies in the kldxref source files, this patch should fix most of them in accordance to style(9)
Some of these were discussed on a previous revision here.
Quick summary:

  • Use designated initializers for structs
  • Always use bracketed return style
  • No initialization in declarations
  • Align function prototype names
  • Remove old commented code/unused imports

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne063_gmail.com created this revision.Jan 16 2018, 10:36 PM
mhorne063_gmail.com added inline comments.Jan 16 2018, 10:47 PM
usr.sbin/kldxref/ef.c
121 ↗(On Diff #38068)

The alignment here is correct, phabricator just doesn't seem to display it properly.

usr.sbin/kldxref/ef_obj.c
139 ↗(On Diff #38068)

Same as above, alignment doesn't display properly in phabricator.

kib added inline comments.Jan 17 2018, 9:35 AM
usr.sbin/kldxref/ef.c
83 ↗(On Diff #38068)

Can you extract the change of the return value to Elf_Off ?

296 ↗(On Diff #38068)

Perhaps use %jx and (uintmax_t)ef_get_offset().

304 ↗(On Diff #38068)

if (error != 0)

mhorne063_gmail.com updated this revision to Diff 38096.Jan 17 2018, 5:59 PM

Use explicit conditions (error != 0).
Remove the change to ef_get_offset() return type for another patch.

mhorne063_gmail.com marked 2 inline comments as done.Jan 17 2018, 6:00 PM
kib accepted this revision.Jan 17 2018, 7:00 PM
This revision is now accepted and ready to land.Jan 17 2018, 7:00 PM
mhorne063_gmail.com updated this revision to Diff 38104.Jan 17 2018, 7:50 PM

Changed pointer justification in the struct at the beginning of ef.c

This revision now requires review to proceed.Jan 17 2018, 7:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 17 2018, 8:00 PM
Closed by commit rS328094: kldxref: improve style(9) (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: andrew, imp. · View Herald TranscriptJan 17 2018, 8:00 PM

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
kldxref/
216 lines
11 lines
114 lines
13 lines
98 lines

Diff 38105

View Options

head/usr.sbin/kldxref/ef.c

Loading...
View Options

head/usr.sbin/kldxref/ef_aarch64.c

Loading...
View Options

head/usr.sbin/kldxref/ef_obj.c

Loading...
View Options

head/usr.sbin/kldxref/ef_powerpc.c

Loading...
View Options

head/usr.sbin/kldxref/kldxref.c

Loading...