Page MenuHomeFreeBSD

if_awg: Use syscon driver if it's specified instead of passing in syscon register
ClosedPublic

Authored by kevans on Nov 29 2017, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 8:19 AM
Unknown Object (File)
Tue, Jun 4, 11:51 AM
Unknown Object (File)
May 4 2024, 3:19 AM
Unknown Object (File)
May 3 2024, 5:32 PM
Unknown Object (File)
May 3 2024, 5:31 PM
Unknown Object (File)
May 3 2024, 5:26 PM
Unknown Object (File)
May 3 2024, 5:26 PM
Unknown Object (File)
May 3 2024, 9:33 AM
Subscribers

Details

Summary

Maintain backwards compatibility with the old method for boards that we get .dtb from u-boot, such as pine64, while accommodating the Linux 4.15 method of using syscon for emac.

Tested on: Banana Pi-M3 (a83t)
Tested on: Pine64 (a64)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 14069

Event Timeline

Allow legacy method of specifying syscon as a register in emac node to remain for now so that we don't break older dts included in u-boot (even as of u-boot -HEAD, as far as I can tell).

This iteration hasn't been tested beyond building, but it's not a major change and I expect no regressions. Even if syscon node+xref exists and syscon register has been left accidentally in emac node, this should still succeed and use sc->syscon due to pass that syscon attaches at.

kevans retitled this revision from if_awg: Use syscon driver instead of passing in syscon register to if_awg: Use syscon driver if it's specified instead of passing in syscon register.Nov 30 2017, 3:10 AM
kevans edited the summary of this revision. (Show Details)

Add dependency on syscon, make sure it's included in GENERIC as well.

Update to reflect syscon adoption into extres framework

Upload correct version with a little more error handling and less redundant initialization

This revision is now accepted and ready to land.Jan 4 2018, 4:37 PM
This revision was automatically updated to reflect the committed changes.