Page MenuHomeFreeBSD
Differential D13684

www/smarty3: Update from 3.1.29 to 3.1.30
ClosedPublic
Actions

Authored by joneum on Dec 29 2017, 9:36 PM.
Tags
None
Referenced Files
F81658254: D13684.diff
Fri, Apr 19, 2:07 PM
Unknown Object (File)
Thu, Apr 18, 7:45 AM
Unknown Object (File)
Thu, Mar 28, 8:22 PM
Unknown Object (File)
Mar 6 2024, 7:27 AM
Unknown Object (File)
Feb 8 2024, 3:09 PM
Unknown Object (File)
Jan 14 2024, 2:05 AM
Unknown Object (File)
Jan 12 2024, 11:47 PM
Unknown Object (File)
Jan 9 2024, 4:59 PM
View All 57 Files
Subscribers
mat

Details

Reviewers
tz
rene
tcberner
Commits
rP458564: www/smarty3: Update from 3.1.29 to 3.1.30
Summary

www/smarty3: Update from 3.1.29 to 3.1.30

Changelog: https://github.com/smarty-php/smarty/blob/v3.1.30/change_log.txt

PR: 224564
Reported by: Matthias Fechner <idefix@fechner.net>
Approved by: maintainer timeout (2 weeks) xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

#(2 weeks Maintainer timeout: 07.01.2018)

poudriere testport:

10.3-amd64
10.3-i386
10.4-amd64
10.4-i386
11.1-amd64
11.1-i386
12.0-CURRENT r325045 amd64
12.0-CURRENT r325045 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13930
Build 14129: arc lint + arc unit

Event Timeline

joneum created this revision.Dec 29 2017, 9:36 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 29 2017, 9:36 PM
tcberner added a comment.Dec 29 2017, 9:40 PM

The pr you linked is from 2017-12-24 10:50:47 UTC -- so still some time for 2 weeks :)

tcberner added inline comments.Dec 29 2017, 9:44 PM
www/smarty3/Makefile
14–15

^ These two likely belong after the USES block

See: 15.9. Standard bsd.port.mk Variables where I think they belong into.

joneum added a comment.Dec 29 2017, 9:46 PM
In D13684#285979, @tcberner wrote:

The pr you linked is from 2017-12-24 10:50:47 UTC -- so still some time for 2 weeks :)

Pls look at Test Plan:

#(2 weeks Maintainer timeout: 07.01.2018)

joneum added inline comments.Dec 29 2017, 9:47 PM
www/smarty3/Makefile
14–15

.www/smarty3: portlint -AC [22:47:01]
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

joneum marked 2 inline comments as done.Dec 29 2017, 10:04 PM
tcberner added inline comments.Dec 29 2017, 10:40 PM
www/smarty3/Makefile
14–15

Well, have you considered, that portlint might not yet have caught on with the documentation =)

mat added inline comments.Dec 29 2017, 10:41 PM
www/smarty3/Makefile
16–17

This is not needed.

joneum updated this revision to Diff 37203.Dec 29 2017, 10:56 PM

Suggested changes from tcberner and mat

Harbormaster completed remote builds in B13929: Diff 37203.Dec 29 2017, 10:56 PM
mat added inline comments.Dec 29 2017, 11:00 PM
www/smarty3/Makefile
21

Mmmm, if you remove this line, you should also remove files/pkg-message.in.

joneum updated this revision to Diff 37205.Dec 29 2017, 11:07 PM

Suggested changes from tcberner and mat

mat added a comment.Dec 30 2017, 8:37 AM

Just to be sure, the content of pkg-message is no longer relevant ?

joneum added a comment.Dec 30 2017, 8:44 AM
In D13684#286191, @mat wrote:

Just to be sure, the content of pkg-message is no longer relevant ?

https://reviews.freebsd.org/D13684#286022
https://reviews.freebsd.org/D13684#286048

"This is not needed."
Your words

mat added a comment.Dec 30 2017, 9:14 AM

I only quoted the PKGMESSAGE line, which is not needed, it will automatically be set when pkg-message is present in SUB_FILES. You then removed both lines, thus what I said afterwards about being consistent.

joneum updated this revision to Diff 37345.Jan 1 2018, 9:51 AM

revert /files and PKGMESSAGE=

Harbormaster completed remote builds in B14026: Diff 37345.Jan 1 2018, 9:52 AM
joneum updated this revision to Diff 37607.Jan 7 2018, 2:00 PM

.

Harbormaster completed remote builds in B14173: Diff 37607.Jan 7 2018, 2:00 PM
joneum added a comment.Jan 9 2018, 3:54 PM

Ping

tcberner accepted this revision.Jan 9 2018, 5:41 PM
This revision is now accepted and ready to land.Jan 9 2018, 5:41 PM
Closed by commit rP458564: www/smarty3: Update from 3.1.29 to 3.1.30 (authored by joneum). · Explain WhyJan 9 2018, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
www/
smarty3/
11 lines
5 lines
9 lines

Diff 37205

View Options

www/smarty3/Makefile

Loading...
View Options

www/smarty3/distinfo

Loading...
View Options

www/smarty3/files/

Loading...
View Options

www/smarty3/files/pkg-message.in

Loading...
View Options

www/smarty3/pkg-plist

Loading...