Do not lock vm map in swapout_procs().
ClosedPublic
Actions

Authored by kib on Dec 29 2017, 7:14 PM.

Tags

None

Referenced Files

	F148633496: D13681.diff
	Thu, Mar 19, 6:41 AM

	F148633489: D13681.diff
	Thu, Mar 19, 6:41 AM

	F148633472: D13681.diff
	Thu, Mar 19, 6:41 AM

	Unknown Object (File)
	Tue, Mar 17, 10:22 PM

	Unknown Object (File)
	Wed, Mar 11, 2:56 AM

	Unknown Object (File)
	Wed, Mar 4, 8:13 AM

	Unknown Object (File)
	Tue, Mar 3, 4:19 PM

	Unknown Object (File)
	Fri, Feb 27, 6:00 AM

View All Files

Subscribers

imp

Details

Reviewers

alc
markj

Commits

rS327359: Do not lock vm map in swapout_procs().

Summary

Neither swapout_procs() nor swapout() access the map.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Dec 29 2017, 7:14 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2017, 7:14 PM

Referencing vmspace is useless after vm_map is not accessed.

alc accepted this revision.Dec 29 2017, 7:40 PM

This revision is now accepted and ready to land.Dec 29 2017, 7:40 PM

Closed by commit rS327359: Do not lock vm map in swapout_procs(). (authored by kib). · Explain WhyDec 29 2017, 8:34 PM

This revision was automatically updated to reflect the committed changes.

Hmm. Do we still need to unlock and relock the process?

_PHOLD_LITE(p);
PROC_UNLOCK(p);
sx_sunlock(&allproc_lock);

PROC_LOCK(p);
if (p->p_lock != 1 || (p->p_flag & (P_STOPPED_SINGLE |
    P_TRACED | P_SYSTEM)) != 0)
        goto nextproc;

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_swapout.c

25 lines

Diff 37192

View Options

Do not lock vm map in swapout_procs().ClosedPublicActions