Do not lock vm map in swapout_procs().
ClosedPublic
Actions

Authored by kib on Dec 29 2017, 7:14 PM.

Tags

None

Referenced Files

	F168955298: D13681.id.diff
	Sun, Aug 30, 10:55 PM

	Unknown Object (File)
	Sun, Aug 30, 4:26 PM

	Unknown Object (File)
	Sun, Aug 30, 4:35 AM

	Unknown Object (File)
	Thu, Aug 27, 11:09 AM

	Unknown Object (File)
	Tue, Aug 25, 2:59 PM

	Unknown Object (File)
	Tue, Aug 25, 5:47 AM

	Unknown Object (File)
	Sun, Aug 23, 11:12 PM

	Unknown Object (File)
	Sun, Aug 23, 6:32 AM

View All Files

Subscribers

imp

Details

Reviewers

alc
markj

Commits

rS327359: Do not lock vm map in swapout_procs().

Summary

Neither swapout_procs() nor swapout() access the map.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Dec 29 2017, 7:14 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2017, 7:14 PM

Referencing vmspace is useless after vm_map is not accessed.

alc accepted this revision.Dec 29 2017, 7:40 PM

This revision is now accepted and ready to land.Dec 29 2017, 7:40 PM

Closed by commit rS327359: Do not lock vm map in swapout_procs(). (authored by kib). · Explain WhyDec 29 2017, 8:34 PM

This revision was automatically updated to reflect the committed changes.

Hmm. Do we still need to unlock and relock the process?

_PHOLD_LITE(p);
PROC_UNLOCK(p);
sx_sunlock(&allproc_lock);

PROC_LOCK(p);
if (p->p_lock != 1 || (p->p_flag & (P_STOPPED_SINGLE |
    P_TRACED | P_SYSTEM)) != 0)
        goto nextproc;

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_swapout.c

25 lines

Diff 37191

View Options

Do not lock vm map in swapout_procs().ClosedPublicActions