Page MenuHomeFreeBSD

Do not lock vm map in swapout_procs().
ClosedPublic

Authored by kib on Dec 29 2017, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:09 AM
Unknown Object (File)
Aug 7 2023, 4:57 AM
Unknown Object (File)
Aug 7 2023, 4:56 AM
Unknown Object (File)
Aug 7 2023, 4:55 AM
Unknown Object (File)
Aug 7 2023, 4:45 AM
Unknown Object (File)
Aug 2 2023, 3:34 AM
Unknown Object (File)
Apr 7 2023, 5:53 PM
Unknown Object (File)
Jan 8 2023, 1:22 PM
Subscribers

Details

Summary

Neither swapout_procs() nor swapout() access the map.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Referencing vmspace is useless after vm_map is not accessed.

This revision is now accepted and ready to land.Dec 29 2017, 7:40 PM
This revision was automatically updated to reflect the committed changes.

Hmm. Do we still need to unlock and relock the process?

_PHOLD_LITE(p);
PROC_UNLOCK(p);
sx_sunlock(&allproc_lock);

PROC_LOCK(p);
if (p->p_lock != 1 || (p->p_flag & (P_STOPPED_SINGLE |
    P_TRACED | P_SYSTEM)) != 0)
        goto nextproc;