www/libmicrohttpd from 0.9.52 to 0.9.58
ClosedPublic
Actions

Authored by joneum on Dec 29 2017, 10:36 AM.

Details

Reviewers

tz
rene
tcberner

Commits

rP457552: www/libmicrohttpd from 0.9.52 to 0.9.58

Summary

www/libmicrohttpd from 0.9.52 to 0.9.58

switch to pkg-plist and from http to https in pkg-descr

Changelog:

Better support for automatic port detection for sockets provided by MHD_OPTION_LISTEN_SOCKET option.
Documentation installation fixes.
Removed usage of 3DES mode from test-suite to avoid test failures on modern platforms.
Minor compiler warning fix.

PR: 224535
Reported by: Greg Fitzgerald <gregf@hugops.pw)
Approved by: Hung-Yi Chen <gaod@hychen.org> (maintainer), xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

poudriere testport:

10.3-amd64
10.3-i386
10.4-amd64
10.4-i386
11.1-amd64
11.1-i386
12.0-CURRENT amd64
12.0-CURRENT i386

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13916
Build 14118: arc lint + arc unit

Event Timeline

joneum created this revision.Dec 29 2017, 10:36 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 29 2017, 10:36 AM

tcberner added inline comments.Dec 29 2017, 9:29 PM

www/libmicrohttpd/Makefile
31	^ you could stick with the PLIST_FILES to reduce the diff

joneum added inline comments.Dec 29 2017, 9:38 PM

www/libmicrohttpd/Makefile
31	Since entries are added, I have intentionally created a pkg-plist

Yes, I read that :D -- I assume because portlint told you to? This looks like a baker's 5 lines to me.

Any particular non-portlint-told-me-to reason?

tcberner added inline comments.Dec 29 2017, 9:48 PM

www/libmicrohttpd/pkg-plist
2	^ this looks like a strange place for an image? is it needed?
3	^ maybe try to get rid of the static library (if it is not too hard -- really needed)

In D13676#285986, @tcberner wrote:

Yes, I read that :D -- I assume because portlint told you to? This looks like a baker's 5 lines to me.

Any particular non-portlint-told-me-to reason?

This had nothing to do with Portlint, but because it makes it so clear. Or is there a counter-argument for not doing it?

joneum added inline comments.Dec 29 2017, 9:50 PM