Page MenuHomeFreeBSD

www/libmicrohttpd from 0.9.52 to 0.9.58
ClosedPublic

Authored by joneum on Dec 29 2017, 10:36 AM.

Details

Summary

www/libmicrohttpd from 0.9.52 to 0.9.58

switch to pkg-plist and from http to https in pkg-descr

Changelog:

  • Better support for automatic port detection for sockets provided by MHD_OPTION_LISTEN_SOCKET option.
  • Documentation installation fixes.
  • Removed usage of 3DES mode from test-suite to avoid test failures on modern platforms.
  • Minor compiler warning fix.

PR: 224535
Reported by: Greg Fitzgerald <gregf@hugops.pw)
Approved by: Hung-Yi Chen <gaod@hychen.org> (maintainer), xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joneum created this revision.Dec 29 2017, 10:36 AM
tcberner added inline comments.Dec 29 2017, 9:29 PM
www/libmicrohttpd/Makefile
31 ↗(On Diff #37177)

^ you could stick with the PLIST_FILES to reduce the diff

joneum added inline comments.Dec 29 2017, 9:38 PM
www/libmicrohttpd/Makefile
31 ↗(On Diff #37177)

Since entries are added, I have intentionally created a pkg-plist

Yes, I read that :D -- I assume because portlint told you to? This looks like a baker's 5 lines to me.

Any particular non-portlint-told-me-to reason?

tcberner added inline comments.Dec 29 2017, 9:48 PM
www/libmicrohttpd/pkg-plist
2 ↗(On Diff #37177)

^ this looks like a strange place for an image? is it needed?

3 ↗(On Diff #37177)

^ maybe try to get rid of the static library (if it is not too hard -- really needed)

Yes, I read that :D -- I assume because portlint told you to? This looks like a baker's 5 lines to me.

Any particular non-portlint-told-me-to reason?

This had nothing to do with Portlint, but because it makes it so clear. Or is there a counter-argument for not doing it?

joneum added inline comments.Dec 29 2017, 9:50 PM
www/libmicrohttpd/pkg-plist
2 ↗(On Diff #37177)

yes

3 ↗(On Diff #37177)

It's a takeover of Makefile

joneum marked 6 inline comments as done.Dec 29 2017, 10:04 PM
tcberner accepted this revision.Dec 29 2017, 10:36 PM

Technically this is fine. Further queries can be directed to my lawyer :D

This revision is now accepted and ready to land.Dec 29 2017, 10:36 PM
This revision was automatically updated to reflect the committed changes.