Minimalistic GUI library for OpenGL
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 13910 Build 14112: arc lint + arc unit
Event Timeline
x11-toolkits/nanogui/Makefile | ||
---|---|---|
41 | Missing EXAMPLES option. |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
45 | more importantly.. shouldn't it be nanogui-python.so. |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
45 |
Because the upstream project isn't yet stable, and such patch is likely going to break.
It does load into python as it is now. Python binding is currently broken, I reported this upstream, but didn't hear back yet. Also, python binding isn't really important for this project, considering its lack of stability and lack of apps using it. It's an experimental part so far, |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
45 | if you know it's broken, why install it by default? |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
45 | Well, this is exactly why a patch is better than using sed in a post-patch target, or moving things around during post-install. Because when the file changes enough that the patch does not apply any more, it means you need to check that what you did at the beginning to see if it still applies, or not, or something else need to be done. When you blindly use sed, you never get noticed that it is obsolete, which is very bad, because it can go on for years, and one day you wonder wtf is these 10 lines of sed doing there that do not do anything at all. |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
45 |
There is no sed in this case. There is ${MV} in this case. :-) |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
45 | I left it "on" because upstream has it "on" by default, also in expectation of it being fixed. |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
45 | Also, it doesn't break anything else, just breaks itself when run. :) |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
19 | ^ are you sure about this one? |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
19 | This is a library using the Eigen headers-only library. |
x11-toolkits/nanogui/Makefile | ||
---|---|---|
27 | ^ This can now be shorter as |
head/x11-toolkits/nanogui/Makefile | ||
---|---|---|
4 ↗ | (On Diff #38505) | What is this for exactly? |
head/x11-toolkits/nanogui/Makefile | ||
---|---|---|
4 ↗ | (On Diff #38505) | This is a small mistake that I will correct with the next update. |