New port: x11-toolkits/nanogui: Minimalistic GUI library for OpenGL

[yuri]

Summary

Minimalistic GUI library for OpenGL

[mat]

x11-toolkits/nanogui/Makefile

40

Missing EXAMPLES option.

[yuri]

Added the missing OPTIONS_DEFINE=EXAMPLES.

[yuri]

Sorry, EXAMPLES were removed.

[tcberner]

x11-toolkits/nanogui/Makefile

6

^ DISTVERSION

46

^ why not patch the CMakeLists.txt to install this to the proper location driectly -- always seems less dirty to me :D

[tcberner]

x11-toolkits/nanogui/Makefile

46

more importantly.. shouldn't it be nanogui-python.so.

[yuri]

x11-toolkits/nanogui/Makefile

46

why not patch the CMakeLists.txt

Because the upstream project isn't yet stable, and such patch is likely going to break.

shouldn't it be nanogui-python.so

It does load into python as it is now. Python binding is currently broken, I reported this upstream, but didn't hear back yet. Also, python binding isn't really important for this project, considering its lack of stability and lack of apps using it. It's an experimental part so far,

[yuri]

.

[tcberner]

x11-toolkits/nanogui/Makefile

46

if you know it's broken, why install it by default?

[mat]

x11-toolkits/nanogui/Makefile

46

Well, this is exactly why a patch is better than using sed in a post-patch target, or moving things around during post-install.

Because when the file changes enough that the patch does not apply any more, it means you need to check that what you did at the beginning to see if it still applies, or not, or something else need to be done.

When you blindly use sed, you never get noticed that it is obsolete, which is very bad, because it can go on for years, and one day you wonder wtf is these 10 lines of sed doing there that do not do anything at all.

[yuri]

x11-toolkits/nanogui/Makefile

46

When you blindly use sed

There is no sed in this case. There is ${MV} in this case. :-)
This ${MV} will break if that file disappeared, or something like that.

[yuri]

x11-toolkits/nanogui/Makefile

46

I left it "on" because upstream has it "on" by default, also in expectation of it being fixed.

[yuri]

x11-toolkits/nanogui/Makefile

46

Also, it doesn't break anything else, just breaks itself when run. :)

[tcberner]

x11-toolkits/nanogui/Makefile

19

^ are you sure about this one?

[yuri]

x11-toolkits/nanogui/Makefile

19

This is a library using the Eigen headers-only library.
It has a dependency on Eigen in a form of #include statements.
So RUN_DEPENDS here is justified.

[yuri]

Updating for USES=eigen.

[tcberner]

x11-toolkits/nanogui/Makefile

27

^ This can now be shorter as
CMAKE_OFF=NANOGUI_BUILD_EXAMPLE GLFW_BUILD_EXAMPLES

[yuri]

CMAKE_OFF

[mat]

head/x11-toolkits/nanogui/Makefile

4 ↗

(On Diff #38505)

What is this for exactly?

[yuri]

head/x11-toolkits/nanogui/Makefile

4 ↗

(On Diff #38505)

This is a small mistake that I will correct with the next update.