Details

Reviewers

Group Reviewers

Commits

rP458513: Remove support for variables that have been deprecated for a while.

Summary

To be exact:

variable	deprecation added	revision	planned expiration date
`WITHOUT_NLS`	2013-12-13	rP336337
`WITH_`/`WITHOUT_`	2014-02-24	rP345870
`NOPORTDOCS`/`NOPORTEXAMPLES`	2014-04-19	rP351587
`WITH_BDB_VER`	2016-05-02	rP414444	2016-08-01
`OVERRIDE_LINUX_BASE_PORT`	2016-09-05	rP421387
`WITH_OPENSSL_`	2016-06-16	rP416965

Test Plan

I expect a big fallout from removing the way PORTDOCS/PORTEXAMPLES work, but it is unavoidable, and easily fixed.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13716
Build 13936: arc lint + arc unit

Event Timeline

mat created this revision.Dec 14 2017, 2:48 PM

Harbormaster completed remote builds in B13560: Diff 36590.Dec 14 2017, 2:48 PM

Of course, someone did that.
Also remove WITH_/WITHOUT_ support as I said.

Harbormaster completed remote builds in B13561: Diff 36591.Dec 14 2017, 2:54 PM

Add a WARNING about the WITH_/WITHOUT_.

Harbormaster completed remote builds in B13562: Diff 36592.Dec 14 2017, 3:03 PM

Make it more clear.

Make it actually work.

Harbormaster completed remote builds in B13564: Diff 36594.Dec 14 2017, 3:14 PM

Add WITH_BDB_VER to the list of removed stuff.

mat retitled this revision from Remove support for NOPORTDOCS, NOPORTDOCS and WITHOUT_NLS, they have been deprecated for a while. to Remove support for variables that have been deprecated for a while..Dec 14 2017, 3:22 PM

mat edited the summary of this revision. (Show Details)

mat edited the summary of this revision. (Show Details)Dec 14 2017, 3:30 PM

OVERRIDE_LINUX_BASE_PORT.
WITH_OPENSSL_*

mat edited the test plan for this revision. (Show Details)Dec 14 2017, 3:37 PM

I expect fallouts so some exp-run would be nice.
Part of this can be committed right now already.

chinese/libtabe/Makefile
48	Can be committed now :)
chinese/p5-Lingua-ZH-TaBE/Makefile
37	This can be committed separatly as in now :)
databases/ruby-bdb/Makefile
12	Can be committed now :)
www/rubygem-passenger/Makefile
47	Can be committed now :)

This revision is now accepted and ready to land.Dec 14 2017, 3:49 PM

In D13490#281980, @bapt wrote:

I expect fallouts so some exp-run would be nice.

Well, I was expecting fallout, but %%PORTDOCS%% and %%PORTEXAMPLES%% work by looking if the option is there, not if the option really exists. I'll patch it a bit more.

There was a hidden NOPORTxxx here.
Only set PORTDOCS/PORTEXAMPLES if their respective options are in OPTIONS_DEFINE.

This revision now requires review to proceed.Dec 14 2017, 4:49 PM

Ok, so with the latest patch, things error out with a:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/3.4.0_to_4.1.0_schema.pgsql.sql
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/dnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/nodnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/schema.pgsql.sql
Error: Orphaned: %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pdns.conf
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/3.4.0_to_4.1.0_schema.pgsql.sql
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/dnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/nodnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/schema.pgsql.sql
Error: Missing: %%PORTEXAMPLES%%@dir %%EXAMPLESDIR%%
Error: Missing: %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pdns.conf

Which is going to get some wtf from people :-)

LGTM overall

Mk/bsd.sanity.mk
6–8	eh, I'd just remove this. years of warnings is enough

bapt added inline comments.Dec 15 2017, 4:46 PM

Mk/bsd.sanity.mk
6–8	I disagree we should say it is unsupported and even maybe replace the WARNING with an ERROR imho. Poisonning variables that used to be documented and used for a while is very important. Lots of old documentation are still available online, on random blogs etc.