syscon: Introduce kobj and split out fdt bits
ClosedPublic
Actions

Authored by kevans on Dec 17 2017, 3:24 PM.

Details

Reviewers

manu
mmel

Group Reviewers

ARM
arm64

Commits

rS327106: syscon: Introduce kobj and split out fdt bits

Summary

Allow more flexibility by kobj'ifying syscon and splitting out fdt specific bits in preparation of a move to the extres framework. The generic fdt driver has been moved to syscon_generic.c and the fdt requirement has been removed from the syscon interface.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 13627

Event Timeline

kevans created this revision.Dec 17 2017, 3:24 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 17 2017, 3:24 PM

manu added reviewers: ARM, arm64.Dec 18 2017, 12:30 PM

Everything else looks OK for me.

sys/dev/syscon/syscon.c
90	I don't think that we needs/wants default methods for read/write/modify. Its better to return error, if driver don't implement these.
227	And whats if single device register multiple syscons? I think that we can store ofw node to struct syscon and then use it for search. OF_device_from_xref() is not right approach I think. see https://github.com/strejda/tegra/blob/master/sys/dev/extres/phy/phy.c#L93 and its usage.