yes, it's not really a problem it's just not "beautiful" :D

In D13235#275741, @tcberner wrote:

yes, it's not really a problem it's just not "beautiful" :D

I am open to other suggestions ;-)

Well, if it is incompatible with the version we have in ports it is BROKEN. And otherwise there is no issue.

But you're probably right, that it is a lot better to track these versions properly :)

Having slept on this, think it's nicer to not change the PORTNAME (and thereby the pkgname) and instead set
WRKSRC.

what do the 2 other mentors @rene and @tz say about that?

In D13235#276797, @joneum wrote:

what do the 2 other mentors @rene and @tz say about that?

About what concretely? After reading the log i'm not sure :D

In D13235#277649, @tz wrote:

In D13235#276797, @joneum wrote:

what do the 2 other mentors @rene and @tz say about that?

About what concretely? After reading the log i'm not sure :D

due to change "PORTNAME = PHPCPD" to "PORTNAME = phpcpd".

I suggest to approve it that way.
I want to repair all ports that are marked as "Broken".
Then test with which PHP versions my pear/pecl ports are running.

Several ports should be changed. Like this one. It's more like a PHP port than a pear port. Also, the name "sebatianbergmann" should be gone. Many ports of his are without his name in the ports.

In D13235#278203, @joneum wrote:

In D13235#277649, @tz wrote:

In D13235#276797, @joneum wrote:

what do the 2 other mentors @rene and @tz say about that?

About what concretely? After reading the log i'm not sure :D

due to change "PORTNAME = PHPCPD" to "PORTNAME = phpcpd".

I suggest to approve it that way.
I want to repair all ports that are marked as "Broken".
Then test with which PHP versions my pear/pecl ports are running.

Several ports should be changed. Like this one. It's more like a PHP port than a pear port. Also, the name "sebatianbergmann" should be gone. Many ports of his are without his name in the ports.

My issue with this is, that you will change the package name twice when doing it like that.

If you could keep it pear-SebastianBergmann-PHPCPD until you rename them all consistently you get one rename.
On the other hand if you do this now and then the other, you essentially do pear-SebastianBergmann-PHPCPD -> pear-SebastianBergmann-phpcpd -> pear-phpcpd which will lead to two ugly upgrades :)

As you can just make the port work with the PORTNAME (and thereby package name) it has now by setting
WRKDIR=${WRKSRC}/phpcpd
I think this is the better route to take.

That being said, I am in favour of better portnames :) you just should try to reduce the annoyance when doing them.

In D13235#278220, @tcberner wrote:

My issue with this is, that you will change the package name twice when doing it like that.

If you could keep it pear-SebastianBergmann-PHPCPD until you rename them all consistently you get one rename.
On the other hand if you do this now and then the other, you essentially do pear-SebastianBergmann-PHPCPD -> pear-SebastianBergmann-phpcpd -> pear-phpcpd which will lead to two ugly upgrades :)

As you can just make the port work with the PORTNAME (and thereby package name) it has now by setting
WRKDIR=${WRKSRC}/phpcpd
I think this is the better route to take.

That being said, I am in favour of better portnames :) you just should try to reduce the annoyance when doing them.

you mean "WRKSRC= ${WRKDIR}/phpcpd"?

In D13235#279260, @joneum wrote:

.

Sorry, I a bit wrong on the order of SRC and DIR there and a bit too abbreviated :)

I would suggest something like

WRKSRC= ${WRKDIR}/${PORTNAME:tl}-${DISTVERSION}

That way you don't need to quirk all the places you need it :)