evel/pear-SebastianBergmann_PHPCPD: Update and Unbreak

[joneum]

Summary

devel/pear-SebastianBergmann_PHPCPD: Update to 2.0.0

Unbreak this port

switch to GitHub

Add LICENSE_FILE

Update *_DEPENDS

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

~/dev/ports/devel/pear-SebastianBergmann_PHPCPD % portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

#PHP5.6
11.1-amd64
11.1-i386

#PHP7.0
11.1-amd64-PHP70
11.1-i386-PHP70

#PHP7.1
11.1-amd64-PHP71
11.1-i386-PHP71

#PHP7.2
11.1-amd64-PHP72
11.1-i386-PHP72

[tcberner]

devel/pear-SebastianBergmann_PHPCPD/Makefile

36

^ do not add comments

40

^remove comment

42

^dasselbe in grün

[tcberner]

devel/pear-SebastianBergmann_PHPCPD/Makefile

4–5

^ I know that you are aware of it, but just as a reminder, you port is now called devel/pear-SebastianBergmann_PHPCPD and the package pear-SebastianBergmann_phpcpd-2.0.0 which may lead to one or the other head being scratched :)

[joneum]

remove testlines from the Makefile

[joneum]

devel/pear-SebastianBergmann_PHPCPD/Makefile

4–5

I'm confused: on the IRC they said this change would be "no problem"

[tcberner]

yes, it's not really a problem it's just not "beautiful" :D

[joneum]

In D13235#275741, @tcberner wrote:

yes, it's not really a problem it's just not "beautiful" :D

I am open to other suggestions ;-)

[joneum]

remove PHP Ignore

[tcberner]

devel/pear-SebastianBergmann_PHPCPD/Makefile

15

is there much point to increasing the version? the ports tree only contains one version at a time, doesn't it? So ">0" should be good enough, and does not require changes every update :)

34

^ I think this is stray, as you opted to use DATADIR now :)

[joneum]

devel/pear-SebastianBergmann_PHPCPD/Makefile

15

it could be incompatible

[tcberner]

Well, if it is incompatible with the version we have in ports it is BROKEN. And otherwise there is no issue.

But you're probably right, that it is a lot better to track these versions properly :)

[joneum]

remove PHP_DIR

[tcberner]

Having slept on this, think it's nicer to not change the PORTNAME (and thereby the pkgname) and instead set
WRKSRC.

[joneum]

what do the 2 other mentors @rene and @tz say about that?

[tz]

In D13235#276797, @joneum wrote:

what do the 2 other mentors @rene and @tz say about that?

About what concretely? After reading the log i'm not sure :D

[joneum]

In D13235#277649, @tz wrote:

In D13235#276797, @joneum wrote:

what do the 2 other mentors @rene and @tz say about that?

About what concretely? After reading the log i'm not sure :D

due to change "PORTNAME = PHPCPD" to "PORTNAME = phpcpd".

I suggest to approve it that way.
I want to repair all ports that are marked as "Broken".
Then test with which PHP versions my pear/pecl ports are running.

Several ports should be changed. Like this one. It's more like a PHP port than a pear port. Also, the name "sebatianbergmann" should be gone. Many ports of his are without his name in the ports.

[tcberner]

In D13235#278203, @joneum wrote:

In D13235#277649, @tz wrote:

In D13235#276797, @joneum wrote:

what do the 2 other mentors @rene and @tz say about that?

About what concretely? After reading the log i'm not sure :D

due to change "PORTNAME = PHPCPD" to "PORTNAME = phpcpd".

I suggest to approve it that way.
I want to repair all ports that are marked as "Broken".
Then test with which PHP versions my pear/pecl ports are running.

Several ports should be changed. Like this one. It's more like a PHP port than a pear port. Also, the name "sebatianbergmann" should be gone. Many ports of his are without his name in the ports.

My issue with this is, that you will change the package name twice when doing it like that.

If you could keep it pear-SebastianBergmann-PHPCPD until you rename them all consistently you get one rename.
On the other hand if you do this now and then the other, you essentially do pear-SebastianBergmann-PHPCPD -> pear-SebastianBergmann-phpcpd -> pear-phpcpd which will lead to two ugly upgrades :)

As you can just make the port work with the PORTNAME (and thereby package name) it has now by setting
WRKDIR=${WRKSRC}/phpcpd
I think this is the better route to take.

That being said, I am in favour of better portnames :) you just should try to reduce the annoyance when doing them.

[joneum]

In D13235#278220, @tcberner wrote:

My issue with this is, that you will change the package name twice when doing it like that.

If you could keep it pear-SebastianBergmann-PHPCPD until you rename them all consistently you get one rename.
On the other hand if you do this now and then the other, you essentially do pear-SebastianBergmann-PHPCPD -> pear-SebastianBergmann-phpcpd -> pear-phpcpd which will lead to two ugly upgrades :)

As you can just make the port work with the PORTNAME (and thereby package name) it has now by setting
WRKDIR=${WRKSRC}/phpcpd
I think this is the better route to take.

That being said, I am in favour of better portnames :) you just should try to reduce the annoyance when doing them.

you mean "WRKSRC= ${WRKDIR}/phpcpd"?

[joneum]

Update Makefile

[joneum]

.

[tcberner]

In D13235#279260, @joneum wrote:

.

Sorry, I a bit wrong on the order of SRC and DIR there and a bit too abbreviated :)

I would suggest something like

WRKSRC= ${WRKDIR}/${PORTNAME:tl}-${DISTVERSION}

That way you don't need to quirk all the places you need it :)

[joneum]

Update WRKSRC=

[tcberner]

[mat]

head/devel/pear-SebastianBergmann_PHPCPD/Makefile

15 ↗

(On Diff #36257)

Out of order. See Chapter 14. Order of Variables in Port Makefiles.

Also, this is wrong, you are using USE_GITHUB, so WRKSRC is always correctly set, if it is not, you are not setting GH_PROJECT correctly.

[joneum]

This comment was removed by joneum.