Page MenuHomeFreeBSD
Differential D13301

Fix various warnings related to geli support.
ClosedPublic
Actions

Authored by imp on Nov 30 2017, 5:38 AM.
Tags
None
Referenced Files
F167021631: D13301.id35996.diff
Tue, Aug 18, 3:28 PM
Unknown Object (File)
Wed, Aug 12, 2:05 PM
Unknown Object (File)
Wed, Aug 12, 2:01 PM
Unknown Object (File)
Tue, Aug 11, 11:02 AM
Unknown Object (File)
Sun, Aug 9, 2:15 AM
Unknown Object (File)
Sat, Aug 8, 11:34 PM
Unknown Object (File)
Fri, Aug 7, 2:12 AM
Unknown Object (File)
Wed, Aug 5, 8:45 AM
View All Files
Subscribers
allanjude
delphij

Details

Reviewers
emaste
tsoome
dteske
allanjude
Commits
rS326448: Fix all warnings related to geli and ZFS support on x86.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13192
Build 13433: arc lint + arc unit

Event Timeline

imp created this revision.Nov 30 2017, 5:38 AM
Harbormaster completed remote builds in B13192: Diff 35996.Nov 30 2017, 5:38 AM
imp added reviewers: emaste, tsoome, dteske.Nov 30 2017, 5:38 AM

not, this doesn't fix them all, but fixes most of the worst of them, including crazy pointer manipulation that I can't understand how it ever worked...

imp added inline comments.Nov 30 2017, 5:40 AM
stand/i386/gptboot/gptboot.c
35–37

I have a more comprehensive fix for issues like this in the pipeline, but it needs a fair amount more time to cook before it's ready.

tsoome accepted this revision.Nov 30 2017, 6:35 AM

Seems good.

This revision is now accepted and ready to land.Nov 30 2017, 6:35 AM
imp updated this revision to Diff 36008.Nov 30 2017, 4:54 PM

Fix the rest.

This revision now requires review to proceed.Nov 30 2017, 4:54 PM
Herald added a subscriber: delphij. · View Herald TranscriptNov 30 2017, 4:54 PM
Harbormaster completed remote builds in B13199: Diff 36008.Nov 30 2017, 4:54 PM
allanjude accepted this revision.Nov 30 2017, 4:59 PM
allanjude added a subscriber: allanjude.

Thanks for cleaning up my mess

This revision is now accepted and ready to land.Nov 30 2017, 4:59 PM
tsoome accepted this revision.Nov 30 2017, 5:03 PM
Closed by commit rS326448: Fix all warnings related to geli and ZFS support on x86. (authored by imp). · Explain WhyDec 2 2017, 12:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
geli/
6 lines
i386/
gptboot/
8 lines
libi386/
6 lines
zfsboot/
10 lines

Diff 35996

View Options

stand/geli/geliboot.c

Loading...
View Options

stand/i386/gptboot/gptboot.c

Loading...
View Options

stand/i386/libi386/biosdisk.c

Loading...
View Options

stand/i386/zfsboot/zfsboot.c

Loading...