Page MenuHomeFreeBSD
Differential D13266

New port: misc/crosti: Convert custom image to cross stitch design, edit stitch designs
ClosedPublic
Actions

Authored by yuri on Nov 27 2017, 7:29 AM.
Tags
None
Referenced Files
F175074238: D13266.id35905.diff
Thu, Oct 8, 1:48 AM
Unknown Object (File)
Sat, Oct 3, 9:40 PM
Unknown Object (File)
Mon, Sep 21, 12:15 AM
Unknown Object (File)
Fri, Sep 18, 4:07 PM
Unknown Object (File)
Wed, Sep 16, 5:28 AM
Unknown Object (File)
Mon, Sep 14, 8:54 AM
Unknown Object (File)
Sun, Sep 13, 6:51 AM
Unknown Object (File)
Thu, Sep 10, 5:36 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP455151: New port: misc/crosti: Convert custom image to cross stitch design, edit stitch…
Summary

Cross-stitch convertor/editor

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13111
Build 13359: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 27 2017, 7:29 AM
Harbormaster completed remote builds in B13103: Diff 35845.Nov 27 2017, 7:29 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 27 2017, 7:29 AM
mat added inline comments.Nov 27 2017, 1:59 PM
misc/crosti/Makefile
19

INSTALL_ICONS is a gnome thing. This port does not use any gnome bits.

yuri updated this revision to Diff 35868.Nov 27 2017, 5:37 PM

.

Harbormaster completed remote builds in B13111: Diff 35868.Nov 27 2017, 5:37 PM
yuri marked an inline comment as done.Nov 27 2017, 5:38 PM
yuri added inline comments.
misc/crosti/Makefile
19

INSTALL_ICONS should be renamed into INSTALL_ICONS_GNOME?

yuri marked an inline comment as done.Nov 27 2017, 5:39 PM
tcberner requested changes to this revision.Nov 27 2017, 8:25 PM

This misses some files

This revision now requires changes to proceed.Nov 27 2017, 8:25 PM
yuri added a comment.Nov 28 2017, 2:53 AM

@tcberner Tobias, what changes are required?

tcberner added a comment.Nov 28 2017, 6:17 AM

It needs the mssing files :)

yuri updated this revision to Diff 35905.Nov 28 2017, 6:26 AM

+missing files

Harbormaster completed remote builds in B13136: Diff 35905.Nov 28 2017, 6:26 AM
tcberner accepted this revision.Nov 29 2017, 8:36 PM
tcberner added inline comments.
misc/crosti/Makefile
18

move USE_GL above USE_QT5

This revision is now accepted and ready to land.Nov 29 2017, 8:36 PM
Closed by commit rP455151: New port: misc/crosti: Convert custom image to cross stitch design, edit stitch… (authored by yuri). · Explain WhyNov 29 2017, 9:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
misc/
1 line
crosti/
21 lines

Diff 35868

View Options

misc/Makefile

Loading...
View Options

misc/crosti/Makefile

Loading...