Only build the libmagic build-tools if MK_FILE != no
ClosedPublic
Actions

Authored by arichardson on Nov 3 2017, 11:27 AM.

Tags

None

Referenced Files

	F168058737: D12925.id34709.diff
	Wed, Aug 26, 4:31 AM

	Unknown Object (File)
	Tue, Aug 25, 6:02 PM

	Unknown Object (File)
	Tue, Aug 25, 12:36 PM

	Unknown Object (File)
	Tue, Aug 25, 12:10 PM

	Unknown Object (File)
	Mon, Aug 24, 7:54 AM

	Unknown Object (File)
	Mon, Aug 24, 4:37 AM

	Unknown Object (File)
	Fri, Aug 21, 1:11 PM

	Unknown Object (File)
	Wed, Aug 19, 10:23 PM

View All Files

Subscribers

None

Details

Reviewers

emaste
jhb
brooks

Commits

rS325772: Only build the libmagic build-tools if MK_FILE != no

Test Plan

WITHOUT_FILE no longer builds libmagic in the build-tools phase.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Nov 3 2017, 11:27 AM

LGTM

This revision is now accepted and ready to land.Nov 3 2017, 11:12 PM

jhb accepted this revision.Nov 13 2017, 6:47 PM

jhb added inline comments.

Makefile.inc1
1974 ↗	(On Diff #34709)	I would perhaps move the new lines up above so they don't come under this comment about kernel-toolchain.

Closed by commit rS325772: Only build the libmagic build-tools if MK_FILE != no (authored by arichardson). · Explain WhyNov 13 2017, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

Makefile.inc1

5 lines

Diff 35206

View Options

Only build the libmagic build-tools if MK_FILE != noClosedPublicActions