Only build the libmagic build-tools if MK_FILE != no
ClosedPublic
Actions

Authored by arichardson on Nov 3 2017, 11:27 AM.

Tags

None

Referenced Files

	F109716759: D12925.diff
	Sat, Feb 8, 4:51 PM

	Unknown Object (File)
	Nov 23 2024, 12:37 AM

	Unknown Object (File)
	Oct 19 2024, 9:22 PM

	Unknown Object (File)
	Oct 14 2024, 10:13 PM

	Unknown Object (File)
	Sep 26 2024, 10:52 PM

	Unknown Object (File)
	Sep 24 2024, 4:23 AM

	Unknown Object (File)
	Sep 9 2024, 7:03 PM

	Unknown Object (File)
	Sep 8 2024, 6:48 PM

View All 39 Files

Subscribers

None

Details

Reviewers

emaste
jhb
brooks

Commits

rS325772: Only build the libmagic build-tools if MK_FILE != no

Test Plan

WITHOUT_FILE no longer builds libmagic in the build-tools phase.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12417
Build 12693: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 3 2017, 11:27 AM

LGTM

This revision is now accepted and ready to land.Nov 3 2017, 11:12 PM

jhb accepted this revision.Nov 13 2017, 6:47 PM

jhb added inline comments.

Makefile.inc1
1974	I would perhaps move the new lines up above so they don't come under this comment about kernel-toolchain.

Closed by commit rS325772: Only build the libmagic build-tools if MK_FILE != no (authored by arichardson). · Explain WhyNov 13 2017, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Makefile.inc1

5 lines

Diff 34709

View Options

Only build the libmagic build-tools if MK_FILE != noClosedPublicActions