Differential D11925

Export std::get_new_handler() from libcxxrt.so
ClosedPublic
Actions

Authored by arichardson on Aug 8 2017, 3:47 PM.

Tags

None

Referenced Files

	F151134396: D11925.id.diff
	Mon, Apr 6, 7:56 AM

	F151105440: D11925.diff
	Mon, Apr 6, 2:39 AM

	Unknown Object (File)
	Sun, Apr 5, 3:38 PM

	Unknown Object (File)
	Sun, Apr 5, 12:16 PM

	Unknown Object (File)
	Sat, Mar 28, 2:09 PM

	Unknown Object (File)
	Thu, Mar 19, 4:38 AM

	Unknown Object (File)
	Wed, Mar 18, 10:50 PM

	Unknown Object (File)
	Sun, Mar 15, 11:00 AM

Subscribers

Details

Reviewers

jhb
theraven
brooks
emaste
dim

Commits

rS325356: Export std::get_new_handler() from libcxxrt.so

Summary

When trying to build world for MIPS64 with clang I was getting
linker errors because of a missing reference to std::get_new_handler().
It turns out std::get_new_handler() was not listed in Version.map so it was
marked as a local symbol in libcxxrt.so.

Obtained from: CheriBSD (https://github.com/CTSRD-CHERI/cheribsd/commit/f33ca065031020e307e21bef9a2074e777111f1e)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12390
Build 12666: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 8 2017, 3:47 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2017, 3:47 PM

emaste added inline comments.Aug 8 2017, 4:40 PM

lib/libcxxrt/Version.map
329	For consistency with stdlibc++ this should go in GLIBCXX_3.4.20, but I don't really know why this is done.

Use GLIBCXX_3.4.20

Harbormaster completed remote builds in B12390: Diff 34663.Nov 2 2017, 9:30 AM

LGTM

This revision is now accepted and ready to land.Nov 2 2017, 12:06 PM

emaste accepted this revision.Nov 2 2017, 1:46 PM

theraven accepted this revision.Nov 2 2017, 2:19 PM

Closed by commit rS325356: Export std::get_new_handler() from libcxxrt.so (authored by arichardson). · Explain WhyNov 3 2017, 12:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libcxxrt/

8 lines

Diff 34663

lib/libcxxrt/Version.map

Loading...