Page MenuHomeFreeBSD
Differential D12764

Fix the VM_NRESERVLEVEL == 0 build
ClosedPublic
Actions

Authored by markj on Oct 23 2017, 12:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 7:46 AM
Unknown Object (File)
Sat, Mar 29, 6:58 AM
Unknown Object (File)
Mar 11 2025, 8:44 PM
Unknown Object (File)
Feb 20 2025, 2:13 AM
Unknown Object (File)
Feb 17 2025, 3:01 AM
Unknown Object (File)
Jan 6 2025, 5:34 AM
Unknown Object (File)
Dec 5 2024, 6:24 PM
Unknown Object (File)
Dec 1 2024, 7:16 PM
View All 59 Files
Subscribers
andrew
emaste

Details

Reviewers
alc
kib
Commits
rS324920: Fix the VM_NRESERVLEVEL == 0 build.
Summary

Add VM_NRESERVLEVEL guards in the pmaps that implement transparent
superpage promotion using reservations.

Test Plan

Verified that a VM_NRESERVELEVEL == 0 amd64 kernel boots.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12182
Build 12481: arc lint + arc unit

Event Timeline

markj created this revision.Oct 23 2017, 12:00 AM
Herald added subscribers: emaste, andrew. · View Herald TranscriptOct 23 2017, 12:00 AM
Harbormaster completed remote builds in B12182: Diff 34244.Oct 23 2017, 12:00 AM
markj edited the test plan for this revision. (Show Details)Oct 23 2017, 12:00 AM
markj added reviewers: alc, kib.
alc added inline comments.Oct 23 2017, 1:01 AM
sys/amd64/conf/BHYVE
5

I presume that this is an unintended leftover from your testing.

markj updated this revision to Diff 34246.Oct 23 2017, 2:20 AM

Remove unintentonal private kernel config update

markj marked an inline comment as done.Oct 23 2017, 2:21 AM
markj added inline comments.
sys/amd64/conf/BHYVE
5

Fixed, thanks.

alc accepted this revision.Oct 23 2017, 4:50 AM
This revision is now accepted and ready to land.Oct 23 2017, 4:50 AM
kib accepted this revision.Oct 23 2017, 7:48 AM
Closed by commit rS324920: Fix the VM_NRESERVLEVEL == 0 build. (authored by markj). · Explain WhyOct 23 2017, 3:34 PM
This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
15 lines
conf/
2 lines
arm/
arm/
7 lines
arm64/
arm64/
6 lines
i386/
i386/
11 lines

Diff 34244

View Options

sys/amd64/amd64/pmap.c

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
#define RSS_HASHTYPE_RSS_IPV4 (1 << 1) #define RSS_HASHTYPE_RSS_IPV4 (1 << 1)
#define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2) #define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2)
#define RSS_HASHTYPE_RSS_IPV6 (1 << 3) #define RSS_HASHTYPE_RSS_IPV6 (1 << 3)
#define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4) #define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4)
#define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5) #define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5)
#define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6) #define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6)
#define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7) #define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7)
#define RSS_HASHTYPE_RSS_UDP_IPV4_EX (1 << 8)
#define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9) #define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9)
#define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10) #define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10)
#define rss_getcpu(_a) 0 #define rss_getcpu(_a) 0
#define rss_getnumbuckets() 1 #define rss_getnumbuckets() 1
#define rss_getkey(_a) #define rss_getkey(_a)
#define rss_get_indirection_to_bucket(_a) 0 #define rss_get_indirection_to_bucket(_a) 0
#define rss_gethashconfig() 0x7E #define rss_gethashconfig() 0x7E
#define rss_hash2bucket(_a,_b,_c) -1 #define rss_hash2bucket(_a,_b,_c) -1
#endif #endif
#endif /* _IXGBE_RSS_H_ */ #endif /* _IXGBE_RSS_H_ */
View Options

sys/amd64/conf/BHYVE

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
#define RSS_HASHTYPE_RSS_IPV4 (1 << 1) #define RSS_HASHTYPE_RSS_IPV4 (1 << 1)
#define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2) #define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2)
#define RSS_HASHTYPE_RSS_IPV6 (1 << 3) #define RSS_HASHTYPE_RSS_IPV6 (1 << 3)
#define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4) #define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4)
#define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5) #define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5)
#define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6) #define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6)
#define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7) #define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7)
#define RSS_HASHTYPE_RSS_UDP_IPV4_EX (1 << 8)
#define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9) #define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9)
#define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10) #define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10)
#define rss_getcpu(_a) 0 #define rss_getcpu(_a) 0
#define rss_getnumbuckets() 1 #define rss_getnumbuckets() 1
#define rss_getkey(_a) #define rss_getkey(_a)
#define rss_get_indirection_to_bucket(_a) 0 #define rss_get_indirection_to_bucket(_a) 0
#define rss_gethashconfig() 0x7E #define rss_gethashconfig() 0x7E
#define rss_hash2bucket(_a,_b,_c) -1 #define rss_hash2bucket(_a,_b,_c) -1
#endif #endif
#endif /* _IXGBE_RSS_H_ */ #endif /* _IXGBE_RSS_H_ */
View Options

sys/arm/arm/pmap-v6.c

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
#define RSS_HASHTYPE_RSS_IPV4 (1 << 1) #define RSS_HASHTYPE_RSS_IPV4 (1 << 1)
#define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2) #define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2)
#define RSS_HASHTYPE_RSS_IPV6 (1 << 3) #define RSS_HASHTYPE_RSS_IPV6 (1 << 3)
#define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4) #define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4)
#define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5) #define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5)
#define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6) #define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6)
#define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7) #define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7)
#define RSS_HASHTYPE_RSS_UDP_IPV4_EX (1 << 8)
#define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9) #define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9)
#define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10) #define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10)
#define rss_getcpu(_a) 0 #define rss_getcpu(_a) 0
#define rss_getnumbuckets() 1 #define rss_getnumbuckets() 1
#define rss_getkey(_a) #define rss_getkey(_a)
#define rss_get_indirection_to_bucket(_a) 0 #define rss_get_indirection_to_bucket(_a) 0
#define rss_gethashconfig() 0x7E #define rss_gethashconfig() 0x7E
#define rss_hash2bucket(_a,_b,_c) -1 #define rss_hash2bucket(_a,_b,_c) -1
#endif #endif
#endif /* _IXGBE_RSS_H_ */ #endif /* _IXGBE_RSS_H_ */
View Options

sys/arm64/arm64/pmap.c

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
#define RSS_HASHTYPE_RSS_IPV4 (1 << 1) #define RSS_HASHTYPE_RSS_IPV4 (1 << 1)
#define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2) #define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2)
#define RSS_HASHTYPE_RSS_IPV6 (1 << 3) #define RSS_HASHTYPE_RSS_IPV6 (1 << 3)
#define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4) #define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4)
#define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5) #define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5)
#define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6) #define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6)
#define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7) #define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7)
#define RSS_HASHTYPE_RSS_UDP_IPV4_EX (1 << 8)
#define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9) #define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9)
#define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10) #define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10)
#define rss_getcpu(_a) 0 #define rss_getcpu(_a) 0
#define rss_getnumbuckets() 1 #define rss_getnumbuckets() 1
#define rss_getkey(_a) #define rss_getkey(_a)
#define rss_get_indirection_to_bucket(_a) 0 #define rss_get_indirection_to_bucket(_a) 0
#define rss_gethashconfig() 0x7E #define rss_gethashconfig() 0x7E
#define rss_hash2bucket(_a,_b,_c) -1 #define rss_hash2bucket(_a,_b,_c) -1
#endif #endif
#endif /* _IXGBE_RSS_H_ */ #endif /* _IXGBE_RSS_H_ */
View Options

sys/i386/i386/pmap.c

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
#define RSS_HASHTYPE_RSS_IPV4 (1 << 1) #define RSS_HASHTYPE_RSS_IPV4 (1 << 1)
#define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2) #define RSS_HASHTYPE_RSS_TCP_IPV4 (1 << 2)
#define RSS_HASHTYPE_RSS_IPV6 (1 << 3) #define RSS_HASHTYPE_RSS_IPV6 (1 << 3)
#define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4) #define RSS_HASHTYPE_RSS_TCP_IPV6 (1 << 4)
#define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5) #define RSS_HASHTYPE_RSS_IPV6_EX (1 << 5)
#define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6) #define RSS_HASHTYPE_RSS_TCP_IPV6_EX (1 << 6)
#define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7) #define RSS_HASHTYPE_RSS_UDP_IPV4 (1 << 7)
#define RSS_HASHTYPE_RSS_UDP_IPV4_EX (1 << 8)
#define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9) #define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9)
#define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10) #define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10)
#define rss_getcpu(_a) 0 #define rss_getcpu(_a) 0
#define rss_getnumbuckets() 1 #define rss_getnumbuckets() 1
#define rss_getkey(_a) #define rss_getkey(_a)
#define rss_get_indirection_to_bucket(_a) 0 #define rss_get_indirection_to_bucket(_a) 0
#define rss_gethashconfig() 0x7E #define rss_gethashconfig() 0x7E
#define rss_hash2bucket(_a,_b,_c) -1 #define rss_hash2bucket(_a,_b,_c) -1
#endif #endif
#endif /* _IXGBE_RSS_H_ */ #endif /* _IXGBE_RSS_H_ */