Details
- Reviewers
bapt bdrewery - Group Reviewers
portmgr - Commits
- rP455205: Generic FLAVORS work.
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 12105 Build 12407: arc lint + arc unit
Event Timeline
- Add a qa check for unique package names amongst flavors.
Its output is something like:
Error: Package names are not uniques with flavors: python2: b2-0.7.2 python3: b2-0.7.2 Error: maybe use <flavor>_PKGNAMEPREFIX/SUFFIX.
- Be a bit more verbose about which FLAVOR is defined when none should be.
- Fix fetch-specials when flavors are in play.
| Mk/bsd.port.mk | ||
|---|---|---|
| 1457 | So, this works just fine on FreeBSD 11.x, but does not work at all on FreeBSD 10.3. Any ideas on how I can make this work ? | |
| CHANGES | ||
|---|---|---|
| 16 ↗ | (On Diff #35192) | Flavors are a way to have multiple variants of a port. |
| CHANGES | ||
|---|---|---|
| 25 ↗ | (On Diff #35687) | "pass the FLAVOR as an argument after make". Your example is not environment, and as far as I can tell it is safer to use it as an argument rather than as environment anyway. |
| 16 ↗ | (On Diff #35192) | I don't think we should use the word 'variant' anywhere as then people ask "Why not call them variants?? I will just do that anyway". And there is prior art for "variant" in macports which seems to be analogous to our OPTIONS and not FLAVORS. |
| Mk/bsd.port.mk | ||
| 1458 | Perfect, thanks! | |
| 4319 | Is DESCRIBE_FLAVORED intended to be DESCRIBE_FLAVORS here and below? The phrase "describe flavored" doesn't make sense to me :) | |
| 4338 | Pass FLAVOR as a make argument please | |
| 4622 | .PHONY | |
| 4628 | Pass FLAVOR as a make argument please | |
| 4632 | .PHONY | |
| 4637 | Pass FLAVOR as a make argument please | |
| CHANGES | ||
|---|---|---|
| 16 ↗ | (On Diff #35192) | I am at a loss of synonyms, what would you want me to use ? I can't use flavor again because I cannot define some word with itself, "version" would be bad... |
| Mk/bsd.port.mk | ||
| 4319 | It may be frenglish :-) | |
| 4338 | It is passed as a make argument, is it not ? | |
| 4622 | I guess many many targets are missing .PHONY here, no ? | |
| 4628 | It is a make argument, isn't it ? | |
| 4637 | it is, no ? | |
| CHANGES | ||
|---|---|---|
| 18 ↗ | (On Diff #35949) | to the flavors |
| 32 ↗ | (On Diff #35949) | Be sure to guard against an empty FLAVOR variable by using ${FLAVOR:U}: |
| 16 ↗ | (On Diff #35192) | I'm not sure that "variant" will be confused for OPTIONS, because we've been pretty clear on what OPTIONS are in FreeBSD for many years. But if not variants: configurations, variations, forms, arrangements. |