Some more basic flavors work.

[mat]

• Move the flavors sanity checks a bit later.

[mat]

rebase.

[mat]

• Add a target showing the different package names of a port.

[mat]

• Add a non pretty target to be used in qa checks.

[mat]

• Add a qa check for unique package names amongst flavors.

Its output is something like:

Error: Package names are not uniques with flavors:
python2: b2-0.7.2
python3: b2-0.7.2
Error: maybe use <flavor>_PKGNAMEPREFIX/SUFFIX.

[mat]

• Make MOVEDlint understand flavors.

[mat]

• Be a bit more verbose about which FLAVOR is defined when none should be.
• Fix fetch-specials when flavors are in play.

[mat]

• fix make clean FLAVOR=xxx

[mat]

remove last commit.

[mat]

rebase.

[mat]

• Add a bit of sanity check to make sure FLAVORS stay lowercase.

[mat]

rebase & squash.

[mat]

rebase after MOVEDlint update.

[mat]

Mk/bsd.port.mk

1461

So, this works just fine on FreeBSD 11.x, but does not work at all on FreeBSD 10.3.

Any ideas on how I can make this work ?

[mat]

• Make the bad FLAVORS name work on 10.

[mat]

rebase

[mat]

• Add support for flavors in the from field.

[mat]

• Add a tentative CHANGES entry.
• Forbid using "all" as a flavor name.

[allanjude]

CHANGES

16 ↗

(On Diff #35192)

Flavors are a way to have multiple variants of a port.

[mat]

• fixup! Add a tentative CHANGES entry.

[bdrewery]

CHANGES

25 ↗

(On Diff #35687)

"pass the FLAVOR as an argument after make". Your example is not environment, and as far as I can tell it is safer to use it as an argument rather than as environment anyway.

16 ↗

(On Diff #35192)

I don't think we should use the word 'variant' anywhere as then people ask "Why not call them variants?? I will just do that anyway". And there is prior art for "variant" in macports which seems to be analogous to our OPTIONS and not FLAVORS.

Mk/bsd.port.mk

1462

Perfect, thanks!

4341

Is DESCRIBE_FLAVORED intended to be DESCRIBE_FLAVORS here and below? The phrase "describe flavored" doesn't make sense to me :)

4360

Pass FLAVOR as a make argument please

4644

.PHONY

4650

Pass FLAVOR as a make argument please

4654

.PHONY

4659

Pass FLAVOR as a make argument please

[mat]

CHANGES

16 ↗

(On Diff #35192)

I am at a loss of synonyms, what would you want me to use ? I can't use flavor again because I cannot define some word with itself, "version" would be bad...

Mk/bsd.port.mk

4341

It may be frenglish :-)
Maybe it should have been FLAVORED_DESCRIBE.

4360

It is passed as a make argument, is it not ?

4644

I guess many many targets are missing .PHONY here, no ?

4650

It is a make argument, isn't it ?

4659

it is, no ?

[mat]

• Small fixes.

[adamw]

CHANGES

18 ↗

(On Diff #35949)

to the flavors

32 ↗

(On Diff #35949)

Be sure to guard against an empty FLAVOR variable by using ${FLAVOR:U}:

16 ↗

(On Diff #35192)

I'm not sure that "variant" will be confused for OPTIONS, because we've been pretty clear on what OPTIONS are in FreeBSD for many years.

But if not variants: configurations, variations, forms, arrangements.

[mat]

• More fixes.

[bdrewery]

DESCRIBE_FLAVORED is still weird but otherwise ship it.

Mk/bsd.port.mk

4341

maybe DESCRIBED_FLAVOR ?

4360

oops