Abstract ZFS preferred device detection
ClosedPublic
Actions

Authored by eric_metricspace.net on Oct 2 2017, 11:31 AM.

Details

Reviewers

imp
allanjude

Commits

rS324360: Encapsulate ZFS preferences into efi_zfs_is_preferred
rS324359: Add efi_devpath_is_prefix

Summary

This is a part of https://reviews.freebsd.org/D10447, and a precursor to that patch.

This abstracts the way that preferred ZFS devices are detected, paving the way for the boot1 refactor.

Test Plan

As of creation, this needs to be tested. The original change did introduce an error, so it needs to be tested with ZFS to ensure that separating it from D10447 didn't introduce new ones.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

eric_metricspace.net created this revision.Oct 2 2017, 11:31 AM

eric_metricspace.net added a child revision: D10447: Unify boot1 with loader.

Confirmed this works in QEMU

Closed by commit rS324359: Add efi_devpath_is_prefix (authored by imp). · Explain WhyOct 6 2017, 12:20 PM

This revision was automatically updated to reflect the committed changes.

These looked good. I've committed it. efi_devpath_is_prefix is a bit of a duplication, but a useful one. It's also not yet used, but I assume further patches will use it.