remove process and jail directory machinations from dounmount
ClosedPublic
Actions

Authored by avg on Sep 14 2017, 11:54 AM.

Details

Reviewers

kib
mckusick
mjg
trasz

Commits

rS324591: remove process and jail directory machinations from dounmount

Summary

The manipulations done by mountcheckdirs() are not that useful during the unmount,
they can bring about unexpected security consequences.

Thic change effectively reverts the change in r73241.
Discussed with Kirk McKusick.

The change also allows to simplify the handling of rootvnode global variable.

Test Plan

Tested with various explicit force unmount scenarios, with a regular reboot and with reboot -r.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11585
Build 11938: arc lint + arc unit

Event Timeline

avg created this revision.Sep 14 2017, 11:54 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 14 2017, 11:54 AM

Harbormaster completed remote builds in B11561: Diff 33061.Sep 14 2017, 11:54 AM

kib added inline comments.Sep 14 2017, 1:54 PM

sys/kern/vfs_mount.c
1366–1367	`(flags & MNT_FORCE) != 0` Why can't you do just `rootvnode != NULL && rootvnode->v_mount == mp` ?

avg added inline comments.Sep 15 2017, 2:05 PM

sys/kern/vfs_mount.c
1366–1367	You are correct, I can do just that and further simplify the code. Thanks!

no need to get a root vnode of the mp to check if it is rootvnode

Harbormaster completed remote builds in B11585: Diff 33108.Sep 15 2017, 2:10 PM

trasz accepted this revision.Oct 11 2017, 10:50 AM

This revision is now accepted and ready to land.Oct 11 2017, 10:50 AM

Closed by commit rS324591: remove process and jail directory machinations from dounmount (authored by avg). · Explain WhyOct 13 2017, 9:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_mount.c

33 lines

Diff 33108

View Options

remove process and jail directory machinations from dounmountClosedPublicActions