Page MenuHomeFreeBSD
Differential D12368

loader: biosmem allocate heap just below 4GB
ClosedPublic
Actions

Authored by tsoome on Sep 14 2017, 12:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 9 2024, 4:29 AM
Unknown Object (File)
Feb 10 2024, 4:08 PM
Unknown Object (File)
Dec 31 2023, 1:36 PM
Unknown Object (File)
Dec 22 2023, 11:47 PM
Unknown Object (File)
Dec 12 2023, 2:42 PM
Unknown Object (File)
Nov 2 2023, 12:00 AM
Unknown Object (File)
Oct 27 2023, 4:35 AM
Unknown Object (File)
Oct 1 2023, 12:00 AM
View All 15 Files
Subscribers
emaste

Details

Reviewers
allanjude
imp
Commits
rS323707: loader: biosmem allocate heap just below 4GB
Summary

The current biosmem code is walking bios smap entries and looking for smap
entry just below 4GB line, if there is such entry, its base and size is set
for heap base and size. Instead of entry base, we should use last HEAP_MIN
(currently 64MB) bytes just below 4GB, to make maximum space for kernel and
modules.

Illumos change: https://www.illumos.org/rb/r/661/

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11570
Build 11923: arc lint + arc unit

Event Timeline

tsoome created this revision.Sep 14 2017, 12:25 PM
Harbormaster completed remote builds in B11563: Diff 33063.Sep 14 2017, 12:25 PM
tsoome edited the summary of this revision. (Show Details)Sep 14 2017, 12:26 PM
emaste added a subscriber: emaste.Sep 14 2017, 12:48 PM

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

imp accepted this revision.Sep 14 2017, 1:59 PM

Change looks OK, but I agree with Ed, it would be better to do the white space changes separately.

This revision is now accepted and ready to land.Sep 14 2017, 1:59 PM
tsoome added a comment.Sep 14 2017, 2:11 PM
In D12368#256547, @emaste wrote:

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

yes, I can do that.

tsoome updated this revision to Diff 33079.Sep 14 2017, 4:46 PM

update after cstyle fix commit.

This revision now requires review to proceed.Sep 14 2017, 4:46 PM
Harbormaster completed remote builds in B11570: Diff 33079.Sep 14 2017, 4:46 PM
imp accepted this revision.Sep 18 2017, 1:18 PM
This revision is now accepted and ready to land.Sep 18 2017, 1:18 PM
Closed by commit rS323707: loader: biosmem allocate heap just below 4GB (authored by tsoome). · Explain WhySep 18 2017, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
i386/
libi386/
19 lines

Diff 33079

View Options

sys/boot/i386/libi386/biosmem.c

Loading...