Page MenuHomeFreeBSD

loader: biosmem allocate heap just below 4GB
ClosedPublic

Authored by tsoome on Sep 14 2017, 12:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 2:28 AM
Unknown Object (File)
Thu, Nov 14, 2:36 AM
Unknown Object (File)
Sun, Oct 20, 4:08 PM
Unknown Object (File)
Sun, Oct 20, 4:08 PM
Unknown Object (File)
Sun, Oct 20, 4:08 PM
Unknown Object (File)
Sun, Oct 20, 4:08 PM
Unknown Object (File)
Sun, Oct 20, 3:21 PM
Unknown Object (File)
Oct 19 2024, 8:44 PM
Subscribers

Details

Summary

The current biosmem code is walking bios smap entries and looking for smap
entry just below 4GB line, if there is such entry, its base and size is set
for heap base and size. Instead of entry base, we should use last HEAP_MIN
(currently 64MB) bytes just below 4GB, to make maximum space for kernel and
modules.

Illumos change: https://www.illumos.org/rb/r/661/

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

Change looks OK, but I agree with Ed, it would be better to do the white space changes separately.

This revision is now accepted and ready to land.Sep 14 2017, 1:59 PM

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

yes, I can do that.

update after cstyle fix commit.

This revision now requires review to proceed.Sep 14 2017, 4:46 PM
This revision is now accepted and ready to land.Sep 18 2017, 1:18 PM
This revision was automatically updated to reflect the committed changes.