Page MenuHomeFreeBSD

Don't complain about missing mountpoints for scripted installations.
ClosedPublic

Authored by rpokala on Sep 12 2017, 9:42 PM.
Tags
None
Referenced Files
F159854006: D12346.id32992.diff
Thu, Jun 18, 8:01 PM
F159840956: D12346.id.diff
Thu, Jun 18, 4:56 PM
F159840351: D12346.id32990.diff
Thu, Jun 18, 4:47 PM
F159797174: D12346.id32991.diff
Thu, Jun 18, 9:49 AM
Unknown Object (File)
Sun, Jun 7, 8:31 AM
Unknown Object (File)
Wed, May 27, 7:38 PM
Unknown Object (File)
Thu, May 21, 7:21 PM
Unknown Object (File)
Apr 29 2026, 7:07 AM

Details

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11531
Build 11885: arc lint + arc unit

Event Timeline

dteske added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056

"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.