Page MenuHomeFreeBSD

Don't complain about missing mountpoints for scripted installations.
ClosedPublic

Authored by rpokala on Sep 12 2017, 9:42 PM.
Tags
None
Referenced Files
F163351750: D12346.id.diff
Wed, Jul 22, 10:19 AM
F163310310: D12346.id32991.diff
Tue, Jul 21, 11:21 PM
F163264149: D12346.id32992.diff
Tue, Jul 21, 1:55 PM
Unknown Object (File)
Wed, Jul 8, 2:54 AM
Unknown Object (File)
Jun 20 2026, 12:15 AM
Unknown Object (File)
Jun 18 2026, 8:01 PM
Unknown Object (File)
Jun 18 2026, 4:56 PM
Unknown Object (File)
Jun 18 2026, 4:47 PM

Details

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11530
Build 11884: arc lint + arc unit

Event Timeline

dteske added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056

"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.