Move EFI FAT creation to here to obviate need for the boot1.efifat file
ClosedPublic
Actions

Authored by nwhitehorn on Sep 10 2017, 5:33 AM.

Details

Reviewers

emaste
allanjude
imp

Summary

Only call partcode_path once.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11475
Build 11830: arc lint + arc unit

Event Timeline

imp created this revision.Sep 10 2017, 5:33 AM

Herald added subscribers: emaste, andrew. · View Herald TranscriptSep 10 2017, 5:33 AM

imp added reviewers: emaste, allanjude, nwhitehorn.Sep 10 2017, 5:36 AM

Let the comments begin :)

usr.sbin/bsdinstall/partedit/gpart_ops.c
450	The more I think of it, the more I am going to create such a script so we can also do u-boot installs in the future if we wanted (though that's even more complex a can of worms).
460	/tmp/junk is obviously lame and should be replaced, perhaps, with something unique. Don't know all the envs this runs in enough to say if that's absolutely needed or not. Plus the use of sprintf instead of snprintf (or even better asprintf) makes my skin crawl, but that's how the rest of the file is written.
809	Sorry for this, and the other, gratuitous white space changes.

imp added inline comments.Sep 10 2017, 2:50 PM

usr.sbin/bsdinstall/partedit/partedit_arm64.c
99	This is also bogus.
usr.sbin/bsdinstall/partedit/partedit_x86.c
145	This change shouldn't be made. It's a vestige of an earlier plan.

Move all the white space changes to a separate commit
Fix some issues with returning the wrong thing
Simplify the system call (though I think we may just want to have a popen

to a script that knows all the cases and rip out most of the knowledge
from here so all creators of images / disks can use it).

Harbormaster completed remote builds in B11475: Diff 32889.Sep 10 2017, 5:20 PM

imp marked 4 inline comments as done.Sep 10 2017, 5:21 PM

allanjude mentioned this in D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.Sep 11 2017, 12:28 AM

allanjude requested changes to this revision.Sep 11 2017, 12:32 AM

allanjude added inline comments.

usr.sbin/bsdinstall/partedit/gpart_ops.c
452	You will need to use -F 16 here, since the ESP is 200MB now. Otherwise you only get a 24MB filesystem: newfs_msdos: warning: FAT type limits file system to 65416 sectors /dev/md0: 65344 sectors in 4084 FAT12 clusters (8192 bytes/cluster) BytesPerSec=512 SecPerClust=16 ResSectors=1 FATs=2 RootDirEnts=512 Sectors=65416 Media=0xf0 FATsecs=12 SecPerTrack=63 Heads=16 HiddenSecs=0 Filesystem Size Used Avail Capacity Mounted on /dev/md0 24M 16K 24M 0% /mnt

This revision now requires changes to proceed.Sep 11 2017, 12:32 AM

The framework in the install to support this ended up being a little different. The updated diff is attached.

Use new general FAT code.

allanjude accepted this revision.Jan 31 2018, 12:55 AM

This revision is now accepted and ready to land.Jan 31 2018, 12:55 AM

This is missing changes for arm and arm64. They also do efi booting and have the horrific boot.efifat hack as well. At least if we support installing from them...

In D12302#296712, @imp wrote:

This is missing changes for arm and arm64. They also do efi booting and have the horrific boot.efifat hack as well. At least if we support installing from them...

For arm64 we absolutely do, performing an install from memstick on arm64 functions exactly as on amd64.

Yes, this is a WIP. Is there anything different about ARM[64] EFI boot vs. amd64? I don't have any such hardware to test on, but I would guess this code can basically be copied and pasted.

I think this is obsoleted by my review at https://reviews.freebsd.org/D17947 ?

Overtaken by events long ago.