Differential D12038

Don't leak lock from os_kmem_alloc().
ClosedPublic
Actions

Authored by jhb on Aug 15 2017, 11:33 PM.

Details

Reviewers

swills
jpaetzel

Commits

rP448159: Don't leak lock from os_kmem_alloc().

Summary

The current port patches for os_kmem_alloc() add VM object locking.
However, the lock is not unlocked in the success case because the
unlock code is inside of an if body instead of after the if statement.

Test Plan

jpaetzel@ confirmed this fixed a panic he was seeing on head. The panic was a WITNESS warning about the lock still being held when an ithread suspended.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 11096
Build 11480: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 15 2017, 11:33 PM

Herald added a subscriber: mat. · View Herald TranscriptAug 15 2017, 11:33 PM

Harbormaster completed remote builds in B11095: Diff 32102.Aug 15 2017, 11:33 PM

The path for the file to be patched is wrong, the original is correct in this case. The code change does fix the kernel panic when the module is loaded.

Fix file path.

Harbormaster completed remote builds in B11096: Diff 32103.Aug 16 2017, 1:24 AM

LGTM

This revision is now accepted and ready to land.Aug 17 2017, 4:48 PM

Approved, thanks!

Closed by commit rP448159: Don't leak lock from os_kmem_alloc(). (authored by jhb). · Explain WhyAug 17 2017, 5:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

emulators/

open-vm-tools/

files/

patch-modules_freebsd_vmmemctl_os.c

20 lines

Diff 32103

View Options

emulators/open-vm-tools/files/patch-modules_freebsd_vmmemctl_os.c

Don't leak lock from os_kmem_alloc().ClosedPublicActions