The current port patches for os_kmem_alloc() add VM object locking.
However, the lock is not unlocked in the success case because the
unlock code is inside of an if body instead of after the if statement.
Details
Details
- Reviewers
swills jpaetzel - Commits
- rP448159: Don't leak lock from os_kmem_alloc().
- jpaetzel@ confirmed this fixed a panic he was seeing on head. The panic was a WITNESS warning about the lock still being held when an ithread suspended.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 11095 Build 11479: arc lint + arc unit
Event Timeline
Comment Actions
The path for the file to be patched is wrong, the original is correct in this case. The code change does fix the kernel panic when the module is loaded.